This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert hint_freed#20746
Merged
Merged
Conversation
zanderso
approved these changes
Aug 25, 2020
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Contributor
Author
|
I suspect the failure is a flake - this code should have no impact on ShellTest.screenshot.... Will rerun. |
Contributor
Author
Contributor
Author
|
Rerun passed. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2020
This was referenced Sep 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused flutter/flutter#64515
I have an idea about how to re-land this in a way that's more targetted towards large images being present and GC-able.
@zanderso @chinmaygarde @jason-simmons