Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Avoid a copy in EncodeImage (#19504)"#19739

Merged
zanderso merged 1 commit into
flutter-team-archive:masterfrom
zanderso:revert-external-encode-image
Jul 14, 2020
Merged

Revert "Avoid a copy in EncodeImage (#19504)"#19739
zanderso merged 1 commit into
flutter-team-archive:masterfrom
zanderso:revert-external-encode-image

Conversation

@zanderso

Copy link
Copy Markdown
Contributor

This reverts commit f9acd08.

Non-genuine TypedData passed to engine.

When the exception was thrown, this was the stack:
#0      _instantiateImageCodec (dart:ui/painting.dart:1760:33)
#1      instantiateImageCodec.<anonymous closure> (dart:ui/painting.dart:1731:12)

@zanderso zanderso requested a review from dnfield July 14, 2020 16:26
@auto-assign auto-assign Bot requested a review from GaryQian July 14, 2020 16:26
@zanderso

Copy link
Copy Markdown
Contributor Author

'Mac iOS Engine' failure was a known flake. Landing revert on red to unblock rolls.

@zanderso zanderso merged commit 72d0c36 into flutter-team-archive:master Jul 14, 2020
@zanderso zanderso deleted the revert-external-encode-image branch July 14, 2020 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants