Wait for platform view to appear in iOS UI tests by jmagman · Pull Request #19725 · flutter-team-archive/engine

jmagman · 2020-07-13T21:45:00Z

Description

Wait for the first platform view to appear before checking its existence.

Related Issues

Tracking down UnobstructedPlatformViewTests flakiness
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8875114005149650384/+/steps/Scenario_App_Integration_Tests/0/stdout

Tests

https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/magder_google.com/d01cc14044ea2ed114f001899bc2bc84c7f4c49270e3f407651a7b4935967ba8/+/annotations?server=chromium-swarm.appspot.com

dnfield

LGTM

blasten · 2020-07-13T22:10:55Z


  XCUIElement* platform_view = app.textViews[@"platform_view[0]"];
-  XCTAssertTrue(platform_view.exists);
+  XCTAssertTrue([platform_view waitForExistenceWithTimeout:1.0]);


jmagman · 2020-07-13T22:52:19Z

Linux Fuchsia retry at https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/11360

jmagman · 2020-07-13T23:21:35Z

"Linux Android Debug Engine" passed even though it's marked pending: https://ci.chromium.org/p/flutter/builders/try/Linux%20Android%20Debug%20Engine/10427?reload=30
"Linux Fuchsia" retry passed: https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/11360

Merging.

…m-archive/engine#19725)

* 160b268 Set locale in Linux shell (flutter-team-archive/engine#19470) * c479b93 Fix documentation of unset platform view ID (flutter-team-archive/engine#19320) * f3ab78d Fix clipboard paste functionality not working (flutter-team-archive/engine#19489) * 9345347 Added the ability to set properties in interface builder for FlutterViewController. (flutter-team-archive/engine#19458) * 69fdf6d Use identical in hashValues instead of operator== (flutter-team-archive/engine#19615) * 3dc8163 [android] Pass synthesized eventType to VirtualDisplay platform views and fix memory leak (flutter-team-archive/engine#19620) * b16c47d using text capitalization value in web (flutter-team-archive/engine#19564) * 49c0161 Roll Skia from 16bf7d31c819 to 4d48bb35972f (32 revisions) (flutter-team-archive/engine#19635) * 2d6afa7 Roll Skia from 4d48bb35972f to 9f821489c9f3 (4 revisions) (flutter-team-archive/engine#19638) * 35f59b9 Roll Fuchsia Linux SDK from NC9pp... to 5R9a0... (flutter-team-archive/engine#19639) * 53038e2 Roll Fuchsia Mac SDK from iwQCA... to Wym-S... (flutter-team-archive/engine#19640) * d9e68f4 Roll Skia from 9f821489c9f3 to f8a6b5b4b0d0 (1 revision) (flutter-team-archive/engine#19643) * d329617 Changes to fix build errors in google3. (flutter-team-archive/engine#19616) * dd0a6c4 Roll Skia from f8a6b5b4b0d0 to 5160e8caa226 (9 revisions) (flutter-team-archive/engine#19647) * d98d539 Manual Roll of Dart dfdc7e45c5...06cb010247 (flutter-team-archive/engine#19649) * dfd0727 don't throw error for the new autofill request (flutter-team-archive/engine#19633) * 39e98d2 Manual Skia roll to c91db040ad18b9cc3236e342e9acca020eaafd10 (flutter-team-archive/engine#19650) * f9acd08 Avoid a copy in EncodeImage (flutter-team-archive/engine#19504) * 7e101f1 Roll Fuchsia Linux SDK from 5R9a0... to GOf1K... (flutter-team-archive/engine#19656) * f3be9f1 Incorporate compat info changes into flutter engine (flutter-team-archive/engine#19606) * 9188ff6 Manual Roll of Dart 707c6404f9...dfdc7e45c5 (flutter-team-archive/engine#19657) * cbdd3e2 Roll Fuchsia Mac SDK from Wym-S... to -v4bL... (flutter-team-archive/engine#19661) * 6efb152 Roll Dart SDK from 707c6404f969 to 0e25306d3f78 (4 revisions) (flutter-team-archive/engine#19666) * 22a440c Roll Dart SDK from 0e25306d3f78 to 6d06476bae6b (1 revision) (flutter-team-archive/engine#19669) * 8063923 Roll Fuchsia Linux SDK from GOf1K... to QWI76... (flutter-team-archive/engine#19671) * c99deb0 CkPaint uses SkPaint (flutter-team-archive/engine#19562) * 015f2ea Use the main bundle if the App bundle is not found (flutter-team-archive/engine#18749) * f82d30b Roll Dart SDK from 6d06476bae6b to a9e67d81941a (3 revisions) (flutter-team-archive/engine#19677) * 61b2fd2 Roll Fuchsia Mac SDK from -v4bL... to phQJt... (flutter-team-archive/engine#19681) * 74b541d Roll Fuchsia Linux SDK from QWI76... to mrlGt... (flutter-team-archive/engine#19682) * 25ce3db Roll Skia from c91db040ad18 to e4f36d7ac8f5 (20 revisions) (flutter-team-archive/engine#19686) * 162dba1 Roll Skia from e4f36d7ac8f5 to ed15b1c39b8b (1 revision) (flutter-team-archive/engine#19687) * f97c38b Roll Fuchsia Mac SDK from phQJt... to kEVc6... (flutter-team-archive/engine#19688) * 40c4ee8 Roll Fuchsia Linux SDK from mrlGt... to YfVT0... (flutter-team-archive/engine#19690) * ec944b0 Roll Skia from ed15b1c39b8b to 1434ce1aa94d (1 revision) (flutter-team-archive/engine#19692) * 7ce988a Roll Skia from 1434ce1aa94d to f64be13cbf84 (2 revisions) (flutter-team-archive/engine#19695) * 5f7ca41 Roll Fuchsia Mac SDK from kEVc6... to hRul_... (flutter-team-archive/engine#19696) * d24549c Roll Skia from f64be13cbf84 to 041796e60364 (3 revisions) (flutter-team-archive/engine#19697) * 617bd88 Roll Dart SDK from a9e67d81941a to fecc8163afc7 (3 revisions) (flutter-team-archive/engine#19703) * 8d241e4 [Android] Prevent FlutterRenderer listener from calling JNI after detach (flutter-team-archive/engine#19558) * 309e514 Roll Skia from 041796e60364 to d1ce4cb2beb8 (2 revisions) (flutter-team-archive/engine#19704) * 211f18e Roll Skia from d1ce4cb2beb8 to 7c1967700b44 (6 revisions) (flutter-team-archive/engine#19707) * 0532227 Roll Skia from 7c1967700b44 to 439709a97dfd (8 revisions) (flutter-team-archive/engine#19712) * 1e02bfd Support decimal information on the TextInputType (flutter-team-archive/engine#19664) * 7a95e32 Linux: Use a hash table to map cursors (flutter-team-archive/engine#19561) * df23044 [web] Implement ulps for path ops (flutter-team-archive/engine#19711) * 4a3aa4d Fixes typo in android_context_gl.h (flutter-team-archive/engine#19700) * 5b966eb Roll Skia from 439709a97dfd to 2604a89d3353 (3 revisions) (flutter-team-archive/engine#19715) * d024ae4 [fuchsia] Use memory_requirements_2 extension. (flutter-team-archive/engine#19678) * 4392fbf Roll Fuchsia Linux SDK from YfVT0... to 2ct5j... (flutter-team-archive/engine#19720) * ab05c79 Roll Fuchsia Mac SDK from hRul_... to ZXLvD... (flutter-team-archive/engine#19721) * c05ca7e Roll Dart SDK from fecc8163afc7 to f997d62a6d29 (13 revisions) (flutter-team-archive/engine#19722) * ae37971 Remove xcpretty from unit tests to see full output on test failures (flutter-team-archive/engine#19667) * 91f80ef Moved to RMSE for image comparison to account for slight variations in golden image tests (flutter-team-archive/engine#19658) * 1e23309 Wait for platform view to appear in iOS UI tests (flutter-team-archive/engine#19725)

Wait for platform view to appear in iOS UI tests

bf58603

jmagman self-assigned this Jul 13, 2020

googlebot added the cla: yes label Jul 13, 2020

jmagman requested a review from gaaclarke July 13, 2020 21:45

auto-assign Bot requested a review from chinmaygarde July 13, 2020 21:45

jmagman mentioned this pull request Jul 13, 2020

[ios] scenario_app flakey: timeout finding platform view flutter/flutter#61267

Closed

dnfield approved these changes Jul 13, 2020

View reviewed changes

blasten reviewed Jul 13, 2020

View reviewed changes

blasten approved these changes Jul 13, 2020

View reviewed changes

jmagman mentioned this pull request Jul 13, 2020

Remove xcpretty from unit tests to see full output on test failures #19667

Merged

jmagman merged commit 1e23309 into flutter-team-archive:master Jul 13, 2020

jmagman deleted the wait-exist branch July 13, 2020 23:21

engine-flutter-autoroll mentioned this pull request Jul 14, 2020

Roll Engine from f10f17257300 to 1e23309a386e (55 revisions) flutter/flutter#61410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

1e23309 Wait for platform view to appear in iOS UI tests (flutter-tea…

b0e31b7

…m-archive/engine#19725)

engine-flutter-autoroll mentioned this pull request Jul 14, 2020

Roll Engine from f10f17257300 to 1e23309a386e (55 revisions) flutter/flutter#61435

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020

1e23309 Wait for platform view to appear in iOS UI tests (flutter-tea…

95d5d9d

…m-archive/engine#19725)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Wait for platform view to appear in iOS UI tests#19725

Wait for platform view to appear in iOS UI tests#19725
jmagman merged 1 commit into
flutter-team-archive:masterfrom
jmagman:wait-exist

jmagman commented Jul 13, 2020 •

edited

Loading

Uh oh!

dnfield left a comment

Uh oh!

blasten Jul 13, 2020

Uh oh!

jmagman commented Jul 13, 2020

Uh oh!

jmagman commented Jul 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

jmagman commented Jul 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Uh oh!

dnfield left a comment

Choose a reason for hiding this comment

Uh oh!

blasten Jul 13, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman commented Jul 13, 2020

Uh oh!

jmagman commented Jul 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

jmagman commented Jul 13, 2020 •

edited

Loading