This repository was archived by the owner on Feb 25, 2025. It is now read-only.
engine cherrypicks for 1.17.1#18290
Merged
pcsosinski merged 2 commits intoMay 12, 2020
Merged
Conversation
cbracken
reviewed
May 12, 2020
cbracken
left a comment
Contributor
There was a problem hiding this comment.
Is this ready for review? Looks like it's still marked as WIP.
Author
|
yup - I think the build failures are okay (recipes not branched) but build_and_test_linux_unopt_debug failing 3x in a row is somewhat new (it usually is flaky but passes on a retry) @christopherfujino |
Contributor
|
Kicked off a re-run of the failing test. |
Author
|
you have the magic touch - it passed. |
tvolkert
approved these changes
May 12, 2020
cbracken
approved these changes
May 12, 2020
cg021
pushed a commit
to cg021/engine
that referenced
this pull request
Jun 1, 2020
* Update 1.17 engine hash to Dart 2.8.2 stable * Hand off presentation properly in VirtualDisplayController.resize() (flutter-team-archive#17897) Co-authored-by: Gary Qian <garyq@google.com>
RRDJ
pushed a commit
to RRDJ/engine-rr
that referenced
this pull request
Jun 2, 2020
* Update 1.17 engine hash to Dart 2.8.2 stable * Hand off presentation properly in VirtualDisplayController.resize() (flutter-team-archive#17897) Co-authored-by: Gary Qian <garyq@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update Dart to 2.8.2
Updating AndroidView layer tree cause 100% crash on some brand device · Issue #26345 · flutter/flutter