Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use iOS 13 dark content status bar style#13119

Merged
cbracken merged 1 commit into
flutter-team-archive:masterfrom
jayjun:dark
Jan 15, 2020
Merged

Use iOS 13 dark content status bar style#13119
cbracken merged 1 commit into
flutter-team-archive:masterfrom
jayjun:dark

Conversation

@jayjun

@jayjun jayjun commented Oct 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

On iOS 13 when Dark Mode is enabled, UIStatusBarStyleDefault uses light text for the status bar instead of dark text.

Since Flutter can only choose between UIStatusBarStyleDefault and UIStatusBarStyleLightContent (light text), the status bar is always white when in Dark Mode.

With this pull request, UIStatusBarStyleDarkContent is specified when dark text is needed.

@jayjun jayjun changed the title Support iOS 13 dark content status bar style Use iOS 13 dark content status bar style Oct 14, 2019
@jayjun jayjun mentioned this pull request Oct 14, 2019
Closed
@chinmaygarde

chinmaygarde commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

We are still in the process of migrating bots to Xcode 11.0 and iOS SDK 13.0. So this won't actually pass the commit bots. The infra update is being tracked in https://github.com/flutter/infra/pull/62 with had to be reverted due to unrelated issues.

cbracken
cbracken approved these changes Oct 21, 2019
View reviewed changes

@cbracken cbracken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@cbracken

cbracken commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

The bots are now updated to Xcode 11.

@chinmaygarde

chinmaygarde commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

@cbracken Are you sure? https://github.com/flutter/infra/commit/f53b002167c06751ef7a603d14f5a8d9e44a178c hasn't relanded but I am not sure if there is some other way to specify the update.

@cbracken

cbracken commented Oct 21, 2019

Copy link
Copy Markdown
Contributor

My mistake -- my understanding is that the devicelab has been updated but I think your bot upgrade PR was reverted?

@darrenaustin darrenaustin mentioned this pull request Oct 21, 2019
Closed
@beeradmoore beeradmoore mentioned this pull request Oct 30, 2019
Closed
@isacjunior

isacjunior commented Oct 31, 2019

Copy link
Copy Markdown

Any prevision or news about to merge this pull request?

@cbracken

cbracken commented Nov 4, 2019

Copy link
Copy Markdown
Contributor

We're going to take another pass at the bots to ensure our infra is updated to Xcode 11 with the iOS 13 SDK then I think we're good to merge.

@jpapay

jpapay commented Nov 19, 2019

Copy link
Copy Markdown

Hey, any prevision or news about merging this pull request ?

@aaronpon

aaronpon commented Nov 27, 2019

Copy link
Copy Markdown

Please merge

@KSubedi

KSubedi commented Dec 4, 2019

Copy link
Copy Markdown

What is the holdup for this merge?

@droplet-js

droplet-js commented Dec 9, 2019

Copy link
Copy Markdown

Any prevision or news about to merge this pull request?

@theneshofficial

theneshofficial commented Dec 9, 2019

Copy link
Copy Markdown

Please merge this request.

@marcoms

marcoms commented Dec 17, 2019

Copy link
Copy Markdown

Hi Flutter team, this issue is quite an important one for a lot of people on account of the fact we now have invisible status bars on iOS. Is there any holdup for merging this PR?

@jaddoescad

jaddoescad commented Dec 19, 2019

Copy link
Copy Markdown

Please Merge

@chavesgu

chavesgu commented Dec 24, 2019

Copy link
Copy Markdown

Please merge

@izabekz

izabekz commented Dec 24, 2019 •
edited
Loading

Copy link
Copy Markdown

@chinmaygarde is there any predictions on when this will be merged?

@sooxt98

sooxt98 commented Dec 26, 2019

Copy link
Copy Markdown

MERGE 🔥🔥🔥

@jaddoescad

jaddoescad commented Dec 30, 2019

Copy link
Copy Markdown

Please merge 😭

@theneshofficial

theneshofficial commented Dec 31, 2019

Copy link
Copy Markdown

Please merge this PR @brianosman

@zakiso

zakiso commented Jan 2, 2020

Copy link
Copy Markdown

Please merge

@Adem68

Adem68 commented Jan 4, 2020

Copy link
Copy Markdown

Please merge -__-

@angelorobo

angelorobo commented Jan 7, 2020

Copy link
Copy Markdown

Please merge!!!

@bruce-brookshire

bruce-brookshire commented Jan 8, 2020

Copy link
Copy Markdown

Please merge 😭

@cbracken

cbracken commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

We expect to get this merged within the next few days. It's pending infra upgrades to XCode 11 and iOS 13 SDK. Good news is those infra updates have started landing yesterday/today. Once we've verified that the upgrades look good and all engine tests are passing, we'll get this landed.

Please use GitHub reactions to thumbs-up/vote on issues rather than adding additional comments; we're also keen to get this landed. Thanks again for the contribution and apologies for the delay in getting our infra upgraded.

@LongCatIsLooong

LongCatIsLooong commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

@cbracken looks like everything is green

@cbracken

cbracken commented Jan 9, 2020

Copy link
Copy Markdown
Contributor

Just landed #12467 which also depends on iOS 13. Assuming infra looks green, I'll land this one next.

@samuelematias

samuelematias commented Jan 15, 2020

Copy link
Copy Markdown

Prediction of this merge T.T ?

@cbracken cbracken merged commit 8101136 into flutter-team-archive:master Jan 15, 2020
@cbracken

cbracken commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

Prediction of this merge T.T ?

10 seconds ago :-) Thanks for the reminder!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020
@engine-flutter-autoroll
8101136 Use iOS 13 dark content status bar style (flutter-team-archiv…
a412f48 
…e/engine#13119)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020
@engine-flutter-autoroll
8101136 Use iOS 13 dark content status bar style (flutter-team-archiv…
dd0b5d8 
…e/engine#13119)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020
@engine-flutter-autoroll
8101136 Use iOS 13 dark content status bar style (flutter-team-archiv…
337fe8e 
…e/engine#13119)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 16, 2020
@engine-flutter-autoroll
8101136 Use iOS 13 dark content status bar style (flutter-team-archiv…
ddb3ea0 
…e/engine#13119)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 16, 2020
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 16, 2020
@engine-flutter-autoroll
Roll engine 3488051..be20fb6 (8 commits) (#48936)
3087625 
flutter-team-archive/engine@3488051...be20fb6

git log 3488051..be20fb6 --first-parent --oneline
2020-01-15 nurhan@google.com [web] Exec command copy (flutter-team-archive/engine#15675)
2020-01-15 chinmaygarde@google.com Disable fml_unittests till flakes are addressed. (flutter-team-archive/engine#15676)
2020-01-15 skia-flutter-autoroll@skia.org Roll src/third_party/dart fe666ce592cb..862d5012ae9c (48 commits) (flutter-team-archive/engine#15672)
2020-01-15 gspencergoog@users.noreply.github.com Fix hardware keyboard enter so it triggers an action. (flutter-team-archive/engine#15568)
2020-01-15 tan@jayjun.com Use iOS 13 dark content status bar style (flutter-team-archive/engine#13119)
2020-01-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from oxHfW... to UlOSN... (flutter-team-archive/engine#15670)
2020-01-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia e45c5cd03eeb..7655168e6865 (29 commits) (flutter-team-archive/engine#15671)
2020-01-15 daniel.nicoara@gmail.com Fix embedder mutation order (flutter-team-archive/engine#15566)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@jayjun jayjun deleted the dark branch January 21, 2020 12:29
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@jayjun @NoamDev
Use iOS 13 dark content status bar style (flutter-team-archive#13119)
fdba8f6
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
Revert "Use iOS 13 dark content status bar style (flutter-team-archiv…
aeb9ee3 
…e#13119)"

This reverts commit fdba8f6.
@NicolasCELLA

NicolasCELLA commented Mar 6, 2020

Copy link
Copy Markdown

Hello, do you have a date for the patch to be operational on our projects ?

Thank you 😇

filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@jayjun @filmil
Use iOS 13 dark content status bar style (flutter-team-archive#13119)
eee96fc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers
@cbracken cbracken cbracken approved these changes
@marcoms marcoms marcoms approved these changes
@jpapay jpapay jpapay approved these changes
@aaronpon aaronpon aaronpon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.