This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Move //third_party/glfw to //flutter/third_party/glfw#777
Merged
Conversation
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This will be followed by an engine PR that updates the deps pull GLFW to //flutter/third_party/glfw and update all targets to point to the new location. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284
matanlurey
approved these changes
Oct 10, 2023
This was referenced Oct 10, 2023
cbracken
added a commit
to flutter-team-archive/engine
that referenced
this pull request
Oct 11, 2023
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter-team-archive/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.
harryterkelsen
pushed a commit
to flutter-team-archive/engine
that referenced
this pull request
Oct 23, 2023
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party. This is the engine-side follow-up to flutter-team-archive/buildroot#777. Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether. Issue: flutter/flutter#136284 No tests changed because there is no semantic change to this PR. This is simply relocating a dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of eliminating the Flutter buildroot (#67373), we are moving all third-party dependencies from //third_party to //flutter/third_party.
This will be followed by an engine PR that updates the deps pull GLFW to //flutter/third_party/glfw and update all targets to point to the new location.
Once all third-party dependencies have been migrated, tooling and config will be moved and the buildroot will be eliminated altogether.
Issue: flutter/flutter#136284
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.