Update iOS app extension document #9698
Conversation
b34120b to
10ad986
Compare
|
@leighajarett I moved the related information from my google dochttps://docs.google.com/document/d/1mWpg1qmCGWG1RreFrOI8-Y3p9usV50MHsECbeoQzDHk/edit) to this doc. Please take a look. |
|
@cyanglaz Looks good to me, besides a few minor comments. When you're ready for tech writers to review, can you assign to @atsansone? |
|
@leighajarett You mentioned "a few minor comments" but I don't see them on the PR. Is your review still a draft? |
|
@leighajarett Friendly ping :) |
| Some app extensions display a user interface. | ||
| For example, iMessage extensions allow users to access your app's | ||
| content directly from the **Messages** app. | ||
| For example, Share Extensions allow users to conveniently share content with other apps. One example of Share Extension is to share a picture and post a comment on a social media app. |
There was a problem hiding this comment.
Is the share extension always accessed from the Photos app @cyanglaz?
There was a problem hiding this comment.
No, Photo app is just an example but it can be accessed from other apps, for example safari
| To create the UI for | ||
| an app extension using Flutter, you must compile | ||
| a custom engine and embed the `FlutterViewController` | ||
| Starting from this [commit](https://github.com/flutter/flutter/commit/3ad9998cf07098d58429aeac242e47a0156ae29c) Flutter supports |
There was a problem hiding this comment.
@atsansone do we usually reference commits for new features or Flutter versions?
There was a problem hiding this comment.
Will update it to 3.16.0
| The Flutter team cautions that only advanced users | ||
| should try to create a custom build. | ||
| To learn more, check out [Compiling the engine][]. | ||
| Due to the memory limits of app extensions, it is only recommanded to use Flutter to build app extension UI for extension types that have memory limits larger than 100mb, Share Extensions for example, which has a 120mb memory limit. In addition, Flutter uses extra memories in debug mode. Thus Flutter does not fully support running app extension in debug mode on physical devices when used to build extension UI. Alternatively, use simulator to test in debug mode. |
There was a problem hiding this comment.
@cyanglaz do you know where developers could find the memory limitations of app extensions? Might be good to let me people know
There was a problem hiding this comment.
Unfortunately, there is no official doc listing all the memory limitations. Developers have to do some research on the extension they want to use. :(
|
Sorry I missed your ping! You're right, I never clicked to submit the review. Submitted now! Let me know if you have any questions |
|
Oh also heads up to tech writers, this goes out in the next stable so ideally we wouldn't push the docs until then |
|
@leighajarett Could you add a "request change" in this PR so it is locked from merging. You can then approve the PR when 3.16.0 moves to stable. |
We would still need these changes to land before the blog goes out as it is linked directly there. Would really like to avoid dead links if possible. CC @parlough |
|
I think we can land this one a bit early. The version change is specifically called out and I doubt it will be pulled at this point. I'll review this shortly. |
|
Okay - I'll refrain from locking for now then |
|
Visit the preview URL for this PR (updated for commit 6c83a2a): https://flutter-docs-prod--pr9698-share-extension-584d9f0l.web.app |
parlough
left a comment
There was a problem hiding this comment.
Thank you!
I pushed a few minor copy and formatting fixes, but otherwise looks good.
Updates the iOS app extension document to reflect the latest support. Fixes flutter/flutter#124293 --------- Co-authored-by: Parker Lougheed <parlough@gmail.com>
Updates the iOS app extension document to reflect the latest support.
Fixes flutter/flutter#124293
Presubmit checklist