Skip to content

Conversation

@TahaTesser
Copy link
Member

Breaking change migration for flutter/flutter#131930

Presubmit checklist

@TahaTesser
Copy link
Member Author

cc: @rydmike
Please let me know if this looks correct and if you've any suggestions.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for always being on top of these breaking change/migration guides!

I haven't taken a close look yet, but can you add this to "Not yet released to stable" in the index: https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L32

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a couple minor edits. @TahaTesser, is this part of the stable release for 3.13? You link to the current API, rather than the master channel API. Have these changes already been landed in the API docs?

@Piinks
Copy link
Contributor

Piinks commented Aug 11, 2023

is this part of the stable release for 3.13? You link to the current API, rather than the master channel API. Have these changes already been landed in the API docs?

@sfshaza2 No, the change has not landed. It is linked in the description: flutter/flutter#131930

@TahaTesser
Copy link
Member Author

Thanks for always being on top of these breaking change/migration guides!

I haven't taken a close look yet, but can you add this to "Not yet released to stable" in the index: https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L32

I think we can add to the "Not yet released to stable" section when flutter/flutter#131930 lands and we've a build tag.

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
Copy link
Member Author

flutter/flutter#131930 landed last night however we don't have the version tag yet.

@parlough
Copy link
Member

Thanks for the update! Should be ready to land this soon then :D

@parlough parlough self-assigned this Aug 28, 2023
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Looks good to me!

I added the "Landed in" version and added the page to the index.

@parlough parlough merged commit b08a4b8 into flutter:main Aug 28, 2023
@TahaTesser TahaTesser deleted the menus_text_style_breaking_change branch August 28, 2023 19:58
@TahaTesser
Copy link
Member Author

@parlough Appreciate it!

atsansone pushed a commit to atsansone/website that referenced this pull request Sep 19, 2023
…9236)

Breaking change migration for
flutter/flutter#131930

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants