-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[breaking-change] Updated default text styles for the menus #9236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking-change] Updated default text styles for the menus #9236
Conversation
|
cc: @rydmike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for always being on top of these breaking change/migration guides!
I haven't taken a close look yet, but can you add this to "Not yet released to stable" in the index: https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L32
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with a couple minor edits. @TahaTesser, is this part of the stable release for 3.13? You link to the current API, rather than the master channel API. Have these changes already been landed in the API docs?
@sfshaza2 No, the change has not landed. It is linked in the description: flutter/flutter#131930 |
I think we can add to the "Not yet released to stable" section when flutter/flutter#131930 lands and we've a build tag. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
flutter/flutter#131930 landed last night however we don't have the version tag yet. |
|
Thanks for the update! Should be ready to land this soon then :D |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Looks good to me!
I added the "Landed in" version and added the page to the index.
|
@parlough Appreciate it! |
…9236) Breaking change migration for flutter/flutter#131930 --------- Co-authored-by: Parker Lougheed <parlough@gmail.com>
Breaking change migration for flutter/flutter#131930
Presubmit checklist