Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jul 25, 2023

relevant flutter/flutter#131287

Presubmit checklist

@chunhtai
Copy link
Contributor Author

cc @Hixie @goderbauer

@Hixie
Copy link
Contributor

Hixie commented Jul 26, 2023

The main thing that's missing here is prose explaining why this feature existed in the first place, and why it is being removed.

@Hixie
Copy link
Contributor

Hixie commented Jul 26, 2023

(e.g. the prose in flutter/flutter#131287)

@chunhtai
Copy link
Contributor Author

(e.g. the prose in flutter/flutter#131287)

updated in the context section

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments...

chunhtai and others added 2 commits July 27, 2023 09:12
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for meeting with me, @chunhtai! Please correct anything that I got wrong.

}
```

## Timeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does you have a release defined for the timeline?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be in the next release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide info on when it was added to beta?

Copy link
Contributor Author

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sfshaza2, I think there were some confusions with ignoreSemantics and IgnorePointer in your previous comments. e.g. ignoreSemantics is not a widget, but a parameter in IgnorePointer.

I tried to follow the same structure you propose, but rephrase the sentences. Let me know if this looks good to you.

@chunhtai chunhtai requested a review from sfshaza2 July 28, 2023 22:47
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! I just found a couple of typos. And can you add this sort of info to timeline:

Landed in version: 3.11.0-0.0.pre<br>
In stable release: TBD

}
```

## Timeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide info on when it was added to beta?

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
@chunhtai
Copy link
Contributor Author

chunhtai commented Aug 2, 2023

Looks pretty good! I just found a couple of typos. And can you add this sort of info to timeline:

Landed in version: 3.11.0-0.0.pre<br>
In stable release: TBD

it is already there in the file, or am i missing something?

Landed in version: 3.10.0-2.0.pre<br>
In stable release: TBD

@chunhtai chunhtai requested a review from sfshaza2 August 2, 2023 20:51
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chunhtai chunhtai merged commit 92f80a5 into flutter:main Aug 3, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants