-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Updates ignoreSemantics migration guide #9124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The main thing that's missing here is prose explaining why this feature existed in the first place, and why it is being removed. |
|
(e.g. the prose in flutter/flutter#131287) |
updated in the context section |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments...
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for meeting with me, @chunhtai! Please correct anything that I got wrong.
| } | ||
| ``` | ||
|
|
||
| ## Timeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does you have a release defined for the timeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be in the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide info on when it was added to beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sfshaza2, I think there were some confusions with ignoreSemantics and IgnorePointer in your previous comments. e.g. ignoreSemantics is not a widget, but a parameter in IgnorePointer.
I tried to follow the same structure you propose, but rephrase the sentences. Let me know if this looks good to you.
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! I just found a couple of typos. And can you add this sort of info to timeline:
Landed in version: 3.11.0-0.0.pre<br>
In stable release: TBD
| } | ||
| ``` | ||
|
|
||
| ## Timeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide info on when it was added to beta?
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
it is already there in the file, or am i missing something? |
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
migration guide update flutter/website#9124 fixes the concerns in #120619
relevant flutter/flutter#131287
Presubmit checklist