Add go link for Impeller Dart doc #8716
Conversation
|
Visit the preview URL for this PR (updated for commit 597e361): https://flutter-docs-prod--pr8716-bdero-patch-1-0a17v1y0.web.app (expires Tue, 06 Jun 2023 00:48:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
parlough
left a comment
There was a problem hiding this comment.
Thanks for adding the redirect.
The doc seems to be private. Can you share by link?
|
This doc is already public: What happens when you try to access it? https://docs.google.com/document/d/1Sh1BAC5c_kkuMVreo7ymBzPoMzb7lamZRPsI7GBXv5M/edit?usp=sharing |
|
I get: 
|
|
Hmm, I'm able to access it on a different Google account though. This time with a resource key which works on the other accounts - https://docs.google.com/document/d/1Sh1BAC5c_kkuMVreo7ymBzPoMzb7lamZRPsI7GBXv5M/edit?resourcekey=0-5w8u2V-LS41tCHeoE8bDTQ Perhaps adjust the link to one with the resource key? |
Co-authored-by: Parker Lougheed <parlough@gmail.com>
|
Hmm interesting, I didn't know stripping this resource key can cause problems. I'll fix this for my previous docs too. |
Nevermind, the generated link for flutter.dev/go/impeller-geometry has no such key. 🤷♂️ |
|
I think it depends on who creates and shares it and their organization's rules. Looks like it is on by default now for new docs created by personal gmail accounts. Thanks for checking though! |
I've been slowly hacking on a prototype alongside a doc (public go link [imminent](flutter/website#8716)) for a while (the doc has been changing a lot as a result of prototyping) and I think it's time to start landing parts of this prototype/experiment in-tree. This initial PR just sets up the main context singleton on the UI thread. After this, I'll land the shader management stuff. I re-used the existing experimental 3D flag for this, since this is meant to replace what can be done with Impeller Scene anyway.
Description of what this PR is changing or adding, and why:
Adds shortlink for a new doc.
Presubmit checklist