Adds migration guide for material localized Strings #8543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @chunhtai! Would you mind if we moved those dart code samples to a project in the examples/ directory so that we can import them as snippets? |
Contributor
Author
|
I am not sure how this would work, some of the code in the snippet may be broken once the change is landed |
Contributor
Author
|
a friendly bump. |
sfshaza2
requested changes
Apr 16, 2023
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
@chunhtai, a few changes. Also, @khanhnwin, can you help @chunhtai with the code snippets, or maybe we don't need it? I defer to you.
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Contributor
Author
|
a friendly bump |
khanhnwin
reviewed
Apr 20, 2023
Contributor
khanhnwin
left a comment
There was a problem hiding this comment.
Let's land this and then I can move the code out to an examples project!
khanhnwin
approved these changes
Apr 20, 2023
Contributor
|
Good to land if it looks good to you @sfshaza2 |
atsansone
added a commit
that referenced
this pull request
Apr 21, 2023
flutter/flutter#124711 ## Presubmit checklist - [ ] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [ ] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [ ] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/master/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Khanh Nguyen <khanhnwin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#124711
Presubmit checklist