Add Linux to platform channel example #8127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Linux section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#108068 This is the Linux equivalent of #7328 Part of flutter/flutter#79204
Contributor
Author
|
I'm just submitting this now this since it's ready and I don't want to lose the edits; this can wait for after the freeze. |
loic-sharma
reviewed
Jan 20, 2023
loic-sharma
reviewed
Jan 20, 2023
loic-sharma
approved these changes
Jan 20, 2023
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
sfshaza2
requested changes
Jan 26, 2023
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
A few tweaks, but otherwise lgtm
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>
stuartmorgan-g
added a commit
that referenced
this pull request
Apr 5, 2023
This adds a macOS section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#123141 This is the macOS equivalent of #7328 and #8127 Fixes flutter/flutter#79204
3 tasks
sfshaza2
pushed a commit
that referenced
this pull request
Apr 5, 2023
This adds a macOS section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#123141 This is the macOS equivalent of #7328 and #8127 Fixes flutter/flutter#79204 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/master/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Linux section to the example implementation instructions, following the same structure as the existing examples, and using the code from flutter/flutter#108068
This is the Linux equivalent of #7328
Part of flutter/flutter#79204