Skip to content

Conversation

@ditman
Copy link
Member

@ditman ditman commented Mar 18, 2022

The old websocket URL used by the cookbook (wss://echo.websocket.org) has been taken down.

This PR updates it with a working echo websocket (wss://echo.websocket.events), graciously provided by Lob, here:

Issues fixed by this PR (if any):

Fixes #6382

Presubmit checklist

@ditman
Copy link
Member Author

ditman commented Mar 18, 2022

PS: I didn't run refresh-code-excerpts.sh (which I assume is what links the .dart examples to the .md documents) because I couldn't find any howtos?

I think I was looking at the CONTRIBUTING, but ended up finding info in the README and here:

@ditman
Copy link
Member Author

ditman commented Mar 18, 2022

OK after initializing the submodules, I could successfully run: ./tool/refresh-code-excerpts.sh:

...
Processed 424 Dart/Jade/Markdown files: 0 out of 623 fragments needed updating.
...

@domesticmouse domesticmouse merged commit bbb5e03 into flutter:main Mar 18, 2022
@sfshaza2
Copy link
Contributor

Thanks so much, @ditman! We do have a how-to for refreshing the code excerpts, but it's on the site-shared repo, which might be hard to find.

@ditman
Copy link
Member Author

ditman commented Mar 21, 2022

@sfshaza2 yes, I expected to find some info on the CONTRIBUTING.md but it was in the README.md (which is probably what people read anyways 😜)

@ditman ditman deleted the fix-websocket-example branch March 21, 2022 18:39
@sfshaza2
Copy link
Contributor

sfshaza2 commented Mar 21, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PAGE ISSUE]: 'Work with WebSockets'

3 participants