Doc for multiple Flutters #5247

xster · 2021-02-02T21:59:22Z

Fixes flutter/flutter#37644.

To merge when the next stable releases.

sfshaza2

I don't know what's up with Travis, but let me kick off the build again.

src/_data/sidenav.yml

src/docs/development/add-to-app/index.md

src/docs/development/add-to-app/multiple-flutters.md

sfshaza2 · 2021-02-03T21:08:35Z

src/docs/development/add-to-app/multiple-flutters.md

+For the 1.26 release, communication between Flutter instances is done using
+[platform channels](https://flutter.dev/docs/development/platform-integration/platform-channels)
+(or [Pigeon](https://pub.dev/packages/pigeon)) via the host platform. To see
+our roadmap on communication or other multiple-Flutters issues, see [flutter/flutter#72009](https://github.com/flutter/flutter/issues/72009).


Suggested change

For the 1.26 release, communication between Flutter instances is done using

[platform channels](https://flutter.dev/docs/development/platform-integration/platform-channels)

(or [Pigeon](https://pub.dev/packages/pigeon)) via the host platform. To see

our roadmap on communication or other multiple-Flutters issues, see [flutter/flutter#72009](https://github.com/flutter/flutter/issues/72009).

As of the 1.26 release, communication between Flutter instances is handled using

[platform channels][] (or [Pigeon][] from the host platform). To see

our roadmap on communication, or other multiple-Flutters issues, see [Issue 72009].

[Issue 72009]: {{site.github}}/flutter/flutter/issues/72009

[Pigeon]: {{site.pub}}/packages/pigeon

[platform channels]: /docs/development/platform-integration/platform-channels

This changes the meaning a bit. I'll tweak it a bit using your wording

src/docs/development/add-to-app/multiple-flutters.md

sfshaza2 · 2021-02-03T23:16:23Z

src/docs/development/add-to-app/multiple-flutters.md

+A sample demonstrating the usage of the new `FlutterEngineGroup` exist at
+https://github.com/flutter/samples/tree/master/add_to_app/multiple_flutters for
+Android and iOS.


That GitHub link gives me a 404.

Suggested change

A sample demonstrating the usage of the new `FlutterEngineGroup` exist at

https://github.com/flutter/samples/tree/master/add_to_app/multiple_flutters for

Android and iOS.

You can find a sample demonstrating how to use `FlutterEngineGroup`

on both Android and iOS on[GitHub][].

[GitHub]: {{site.github}}/flutter/samples/tree/master/add_to_app/multiple_flutters

ya, there is indeed a bit of logistical gymnastics needed here. The samples PRs aren't merged in currently since the samples repo need to build on stable and the new samples are using new APIs created after the last stable. We would want to merge that sample when the next stable releases.

Should I remove this line for now so that this PR is mergeable and we can add it when the samples merge after the stable release?

src/docs/development/add-to-app/performance.md

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

sfshaza2

LGTM

sfshaza2 · 2021-02-10T18:40:56Z

@gaaclarke, are you good with this PR? I'd like to land it. :)

xster · 2021-02-10T19:05:44Z

We can't merge this PR yet until we resolve https://docs.google.com/document/d/140-Jc6GIDy7XvAglpI92HAoUpg3oCZh-H1S0XCqluCo/edit?disco=AAAALXIywMo (unless you're ok with a broken link in the meantime).

gaaclarke · 2021-02-10T19:07:56Z

Yes, this looks good. I have two comments:

@xster and I were talking and it would be nice to mention that platform views aren't supported.
I have a bit of a niggle about calling this thing "multiple flutters" officially. I wonder if talking about "FlutterEngineGroup" would be more clear. Instead of naming it by an abstraction of the use case, calling it the name of the API.

xster · 2021-02-10T20:38:33Z

src/docs/development/add-to-app/multiple-flutters.md

+our roadmap on communication, or other multiple-Flutters issues, see [Issue 72009][].
+
+{{site.alert.warning}}
+  In 1.26, the use of [platform views][] is not supported in conjunction with


@gaaclarke did I get this right?

Sounds good.

xster · 2021-02-10T20:40:35Z

I'm assuming you're referring to the sidenav menu name right? I'd be for keeping it consistent with the rest of the add to app content (in the form of "Add to an iOS app / Add a single Flutter screen" rather than "FlutterViewController"). I think it's a bit more approachable for users who have a goal in mind, and then match an API to the goal after reading the doc.

xster · 2021-02-11T21:46:54Z

Actually the URL is already present. That's why CI was passing. Merging this.

xster requested review from gaaclarke and sfshaza2 February 2, 2021 21:59

google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Feb 2, 2021

sfshaza2 requested changes Feb 3, 2021

View reviewed changes

Doc for multiple Flutters

a16faca

xster force-pushed the multiple-flutters branch from dce28e9 to a16faca Compare February 9, 2021 21:24

xster and others added 2 commits February 9, 2021 13:30

review suggestions

37c865c

Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com>

review

54683a2

sfshaza2 approved these changes Feb 10, 2021

View reviewed changes

platform view caveat

04c381d

xster commented Feb 10, 2021

View reviewed changes

xster force-pushed the multiple-flutters branch from a47285f to 04c381d Compare February 11, 2021 21:45

xster merged commit 9f9fe7f into flutter:master Feb 11, 2021

xster deleted the multiple-flutters branch February 11, 2021 21:47

filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021

Doc for multiple Flutters (flutter#5247)

20ec38a

-For the 1.26 release, communication between Flutter instances is done using
-[platform channels](https://flutter.dev/docs/development/platform-integration/platform-channels)
-(or [Pigeon](https://pub.dev/packages/pigeon)) via the host platform. To see
-our roadmap on communication or other multiple-Flutters issues, see [flutter/flutter#72009](https://github.com/flutter/flutter/issues/72009).
+As of the 1.26 release, communication between Flutter instances is handled using
+[platform channels][] (or [Pigeon][] from the host platform). To see
+our roadmap on communication, or other multiple-Flutters issues, see [Issue 72009].
+[Issue 72009]: {{site.github}}/flutter/flutter/issues/72009
+[Pigeon]: {{site.pub}}/packages/pigeon
+[platform channels]: /docs/development/platform-integration/platform-channels

Doc for multiple Flutters #5247

Doc for multiple Flutters #5247

Uh oh!

Conversation

xster commented Feb 2, 2021

Uh oh!

sfshaza2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfshaza2 Feb 3, 2021

Choose a reason for hiding this comment

Uh oh!

xster Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfshaza2 Feb 3, 2021

Choose a reason for hiding this comment

Uh oh!

xster Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sfshaza2 left a comment

Choose a reason for hiding this comment

Uh oh!

sfshaza2 commented Feb 10, 2021

Uh oh!

xster commented Feb 10, 2021

Uh oh!

gaaclarke commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xster Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

gaaclarke Feb 10, 2021

Choose a reason for hiding this comment

Uh oh!

xster commented Feb 10, 2021

Uh oh!

xster commented Feb 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gaaclarke commented Feb 10, 2021 •

edited

Loading