Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 5, 2020

Update add-to-app iOS instructions to use flutter build ios-framework --xcframework in anticipation of Apple Silicon support.

--xcframework became the default as of flutter/flutter#69720.

New image:
embed-xcode
Samples also updated at flutter/samples#582.

@jmagman jmagman requested review from sfshaza2 and xster November 5, 2020 04:26
@jmagman jmagman self-assigned this Nov 5, 2020
@google-cla google-cla bot added the cla: yes Contributor has signed the Contributor License Agreement label Nov 5, 2020
@xster
Copy link
Member

xster commented Nov 5, 2020

LGTM.

Did you optipng the image? Slightly surprised the similar dimension image doubled in size.

@jmagman
Copy link
Member Author

jmagman commented Nov 5, 2020

Did you optipng the image? Slightly surprised the similar dimension image doubled in size.

I tried npx gulp compress-images --path based on https://github.com/dart-lang/site-shared/blob/master/doc/images.md but maybe it didn't do anything.

@xster
Copy link
Member

xster commented Nov 5, 2020

@jmagman
Copy link
Member Author

jmagman commented Nov 5, 2020

Try https://flutter.github.io/assets-for-api-docs/#optimization

It's 150% larger instead of 190% now, but it's still only 162KB.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit 8da08ec into flutter:master Nov 5, 2020
@jmagman jmagman deleted the xcframework branch November 5, 2020 20:06
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
* Add to app prebuilt binaries as xcframeworks

* optipng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants