Skip to content

Conversation

@xster
Copy link
Member

@xster xster commented Sep 2, 2020

For the soft visual breaking change in flutter/flutter#65083.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for that one piece of feedback on the timeline, this LGTM.


## Timeline

Landed in: https://github.com/flutter/flutter/pull/65083<br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we translate this to something meaningful, like 1.22? I've tried and can't figure it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfshaza2 sfshaza2 merged commit 760b42b into flutter:master Sep 10, 2020
@xster xster deleted the cupertino-icon branch September 10, 2020 07:36
filiph pushed a commit to filiph/website that referenced this pull request Feb 22, 2021
)

* Add breaking change doc for cupertino icons package update

* change version format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants