Add TestWidgetsFlutterBinding.clock migration guide#3932
Merged
sfshaza2 merged 4 commits intoflutter:masterfrom Apr 22, 2020
Merged
Add TestWidgetsFlutterBinding.clock migration guide#3932sfshaza2 merged 4 commits intoflutter:masterfrom
sfshaza2 merged 4 commits intoflutter:masterfrom
Conversation
13 tasks
Contributor
|
Thanks for raising this @jakemac53. You can prepend the issue with "[WIP] add testWidgetsFlutterBinding.clock..." and our CI will block this PR from being merged until you remove the "[WIP]" from the issue title. Does that help? |
Hixie
reviewed
Apr 9, 2020
src/docs/release/breaking-changes/test-widgets-flutter-binding-clock.md
Outdated
Show resolved
Hide resolved
src/docs/release/breaking-changes/test-widgets-flutter-binding-clock.md
Outdated
Show resolved
Hide resolved
Contributor
|
So, @jakemac53, if you have the commit for this change, it says which release it's merged into. Once we have that, we can publish. |
Contributor
Author
|
Yep, I am just giving people a chance to respond to the breaking change doc etc before merging. I will update here and remove the [WIP] tag once ready. |
jakemac53
added a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2020
) ## Description Removes the `flutter_test` dependency on `quiver`, instead using the more targeted `clock` and `fake_async` packages. ## Related Issues #53908 ## Tests No changes to tests ## Checklist Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I signed the [CLA]. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] All existing and new tests are passing. - [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR. - [x] I am willing to follow-up on review comments in a timely manner. ## Breaking Change Did any tests fail when you ran them? Please read [Handling breaking changes]. - [ ] No, no existing tests failed, so this is *not* a breaking change. - [x] Yes, this is a breaking change. *If not, delete the remainder of this section.* - [x] I wrote a design doc: https://docs.google.com/document/d/1EkkLbECNBwHgddBQAZqEy7iQLTIxR1rgChKzxcLwhio/edit - [x] I got input from the developer relations team, specifically from: @redbrogdon - [x] I wrote a migration guide: flutter/website#3932 <!-- Links --> [issue database]: https://github.com/flutter/flutter/issues [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
Contributor
Author
|
PR is merged, just waiting for it to appear in a tagged release then I can add that here |
Contributor
|
@jakemac53, I see the PR is merged into 1.18.0-6.0.pre. I'd just say 1.18.0 in the breaking change file. Let's get this landed! :D (I see @redbrogdon approved of the migration guide in the flutter/flutter PR.) |
Contributor
|
By the way, I didn't need the [WIP] designation on the PR. I'm the only one who merges PRs on this repo and I would never merge it until the release # is added. |
Contributor
Author
|
Done! |
sfshaza2
approved these changes
Apr 22, 2020
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
LGTM! Once Travis is happy, I will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change has not yet actually landed - I am not sure the protocol exactly on that (should I wait to merge this until I know the release number it will land in etc, or leave that as unspecified here?).