doc for resolution aware images #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @krisgiesing ptal |
resolution-aware-images.md
Outdated
Contributor
There was a problem hiding this comment.
I forgot to mention, but we should explain somewhere in here, that Flutter's build phase now automatically picks up any asset variants in subfolders that have the same name as a main asset. So if you declare my_icon.png in the example below, the build phase will automatically include 2.0x/my_icon.png and 3.0x/my_icon.png in the asset bundle.
Contributor
Author
There was a problem hiding this comment.
Ah, so the developer only needs to add my_icon.png to their flutter.yaml ?
Contributor
Author
There was a problem hiding this comment.
What did you mean "the asset bundle" ?
Contributor
There was a problem hiding this comment.
When flutter builds an app it creates a bundle of assets that are accessible through the class AssetBundle (and the widget DefaultAssetBundle). Maybe we should have separate documentation on that somewhere?
Contributor
|
Thanks for taking this on. I didn't realize until reading it in this context how colloquially it was worded for the benefit of the mailing list. |
Contributor
Author
|
All good. You took the time to write a detailed email, I wanted to capture that. Please feel free to tweak this doc. |
eb709fa to
9eeb01e
Compare
resolution-aware-images.md
Outdated
Contributor
There was a problem hiding this comment.
Let's move this tip down below where we talk about my_icon.
Contributor
|
LGTM after moving the Tip: paragraph. |
9eeb01e to
5fd98e4
Compare
sethladd
added a commit
that referenced
this pull request
Feb 3, 2016
doc for resolution aware images
khanhnwin
pushed a commit
that referenced
this pull request
May 10, 2023
Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `f34ebd8` to `ec39689`. - [Release notes](https://github.com/flutter/codelabs/releases) - [Commits](flutter/codelabs@f34ebd8...ec39689) --- updated-dependencies: - dependency-name: examples/codelabs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
khanhnwin
added a commit
that referenced
this pull request
May 10, 2023
- Bump site-shared from `04a5353` to `74292e2` (#153) - io23 bring up to date (#154) - Update PULL_REQUEST_TEMPLATE.md - Update build.yml - Bump examples/codelabs from `f34ebd8` to `ec39689` (#155) - Bump github/codeql-action from 2.3.0 to 2.3.1 (#156) - Bump github/codeql-action from 2.3.1 to 2.3.2 (#159) - Bump examples/codelabs from `ec39689` to `f5011e7` (#158) - Bump examples/codelabs from `f5011e7` to `b7d1dd0` (#161) - Bump site-shared from `74292e2` to `d514327` (#160) - Bump examples/codelabs from `b7d1dd0` to `b53da25` (#163) - Update Codelabs page with NG UI lab (#162) - Update wasm landing page for I/O '23 (#157) - Bump pigeon from 9.2.5 to 10.0.0 in /examples/development/platform_integration (#166) - Bump ruby from 3.2-2-slim-bullseye to 3.2.2-slim-bullseye (#169) - Update supported-platforms.md (#168) - [web] Document new HTML embedding options. (#164) - Flutter 3.10 release notes (#170) - Enable tests on `beta` branch and update examples (#172) - Bump actions/checkout from 3.5.0 to 3.5.2 (#175) - Bump github/codeql-action from 2.3.2 to 2.3.3 (#174) - Bump examples/codelabs from `b53da25` to `af7e9a9` (#173) - Add Swift Package Manager design doc go link (#171) - Enable link check workflow (#176) - Update language version to Dart 3 in examples (#178) - wasm: small update (#180) - Add PaLM codelab (#179) - Updated breaking changes for 3.10 (#177) - Update What's New for 3.10 (#165) - Tweak to wasm page (#181) - Bump examples/codelabs from `af7e9a9` to `007143a` (#182) - Added new banner for I/O 2023 announcement (#183) - restore build.yml --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shams Zakhour (ignore Sfshaza) <44418985+sfshaza2@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: 失魂魚 <satwanjyu@outlook.com> Co-authored-by: Brett Morgan <brettmorgan@google.com> Co-authored-by: Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by: Dimitris Paxinos <dpaxinos@gmail.com> Co-authored-by: Elias Yishak <42216813+eliasyishak@users.noreply.github.com> Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com> Co-authored-by: Anthony Sansone <atsansone@users.noreply.github.com> Co-authored-by: Leigha Jarett <leighaj@google.com> Co-authored-by: Victoria Ashworth <vashworth@google.com> Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by: Eilidh Southren <esouthren@google.com> Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Stefanie Luo <111539762+stef-luo@users.noreply.github.com> Co-authored-by: Chris Bracken <chris@bracken.jp> Co-authored-by: David Iglesias <ditman@gmail.com> Co-authored-by: John Ryan <ryjohn@google.com> Co-authored-by: Yegor <yjbanov@google.com> Co-authored-by: Kevin Chisholm <kevinjchisholm@google.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: Tim Sneath <timsneath@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#1530