Fixed swift code #12110
Merged
Fixed swift code #12110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Collaborator
|
Visit the preview URL for this PR (updated for commit bc95120): https://flutter-docs-prod--pr12110-updated-swift-example-uisce-nok55w1q.web.app |
sfshaza2
approved these changes
Jun 10, 2025
Contributor
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm, once you and @stuartmorgan-g reach agreement
ericwindmill
pushed a commit
that referenced
this pull request
Jun 24, 2025
_Description of what this PR is changing or adding, and why:_ Updated the swift example code to match the compiled swift example: https://github.com/flutter/flutter/blob/1b9502b007d01e1cc79dd86fc3300061522803a5/examples/platform_channel_swift/ios/Runner/AppDelegate.swift#L33 There were syntactic errors in the swift code which isn't checked like the dart code. _Issues fixed by this PR (if any):_ _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why:
Updated the swift example code to match the compiled swift example: https://github.com/flutter/flutter/blob/1b9502b007d01e1cc79dd86fc3300061522803a5/examples/platform_channel_swift/ios/Runner/AppDelegate.swift#L33
There were syntactic errors in the swift code which isn't checked like the dart code.
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist