Skip to content

Conversation

@DanTup
Copy link
Contributor

@DanTup DanTup commented Sep 2, 2025

This bumps assorted_layout_widgets to the latest version. The current version is around 10 months old and excludes some changes made to remove obsolete lints that are preventing landing a change to the analysis server to produce warnings for that.

Specifically, we want the PR from @pq merged at marcglasberg/assorted_layout_widgets#37 that removes prefer_equal_for_default_values to unblock @FMorschel's change at https://dart-review.googlesource.com/c/sdk/+/448063.

This bumps assorted_layout_widgets to the latest version. The current version is around 10 months old and excludes some changes made to remove obsolete lints that are preventing landing a change to the analysis server to produce warnings for that.
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 2, 2025

autosubmit label was removed for flutter/tests/469, because - The status or check suite windows_tests (shard 1 of 5, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite linux_tests (shard 1 of 3, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@DanTup
Copy link
Contributor Author

DanTup commented Sep 2, 2025

This still fails because:

| warning • The declaration '_deprecated' isn't referenced • example/lib/main_side_by_side.dart:83:10 • unused_element

This example file has a method _deprecated() and the code to call it is commented out:

https://github.com/marcglasberg/assorted_layout_widgets/blob/master/example/lib/main_side_by_side.dart

Assuming the code isn't to be deleted, probably this needs an ignore comment (and once committed, we'll need to update this hash again).

Closing this PR for now since it can't land until updates are made to that project.

@DanTup DanTup closed this Sep 2, 2025
auto-submit bot pushed a commit that referenced this pull request Sep 5, 2025
…287 (#470)

This bumps `assorted_layout_widgets` to the latest version. The current version is around 10 months old and excludes some changes made to remove obsolete lints that are preventing landing a change to the analysis server to produce warnings for that.

Specifically, we want the PR from @pq merged at marcglasberg/assorted_layout_widgets#37 that removes `prefer_equal_for_default_values` and mine merged at marcglasberg/assorted_layout_widgets#41 to fix the error we found at #469 to unblock my change at https://dart-review.googlesource.com/c/sdk/+/448063.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant