Revert "Disable flutter_devtools.test" #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56da415.
matanlurey
requested changes
Apr 15, 2025
Contributor
matanlurey
left a comment
There was a problem hiding this comment.
Can you clarify before doing this, does this test validate the content of the (stable) docs.flutter.dev?
If so this doesn't belong in customer_tests, and violates customer_testing test guidelines:
Tests must be hermetic. For example, a test should not involve network activity
Adding this again means if docs.flutter.dev ever changes, the entire Flutter tree breaks (for hours) out of band, like it did today. If that's not what the test does, apologies, and I'm happy to stamp.
Member
Author
I'm not sure which DevTools test was broken by flutter/website@99d9296. @bkonyi can you comment what the original failure was that led you to disable the DevTools tests in #452? |
Contributor
See https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/23580/overview The failing test does hit the network. |
Member
Author
|
flutter/devtools#9150 landed in DevTools to disable the test in question for the customer test registry. I have updated the Devtools hash here to include that change, so this should be good to land once tests pass and the PR is approved. |
matanlurey
approved these changes
Apr 17, 2025
Contributor
matanlurey
left a comment
There was a problem hiding this comment.
LGTM! Thanks for doing that.
gnprice
added a commit
to gnprice/flutter
that referenced
this pull request
Apr 24, 2025
This pulls in the 4 commits below: flutter/tests@8be7209...c9cbc60 2025-04-24 greg@zulip.com Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 43759233+kenzieschmoll@users.noreply.github.com Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 aam@google.com Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 bkonyi@google.com Disable flutter_devtools.test (flutter/tests#452) (using the command from 5ce5251 / flutter#162763 to make the log). The two changes from 2025-04-15 had been here since db68c95 (flutter#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (flutter#165596). The change from 04-17 doesn't appear to have made it here to flutter/flutter yet. The latest change just went into flutter/tests today and is why I'm making this PR.
9 tasks
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 24, 2025
This pulls in the 4 commits below: flutter/tests@8be7209...c9cbc60 2025-04-24 greg@zulip.com Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 43759233+kenzieschmoll@users.noreply.github.com Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 aam@google.com Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 bkonyi@google.com Disable flutter_devtools.test (flutter/tests#452) (using the command from 5ce5251 / #162763 to make the log). The two changes from 2025-04-15 had been here since db68c95 (#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (#165596). The change from 04-17 doesn't appear to have made it here to flutter/flutter yet. The latest change just went into flutter/tests today and is why I'm making this PR. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
…7754) This pulls in the 4 commits below: flutter/tests@8be7209...c9cbc60 2025-04-24 greg@zulip.com Bump Zulip pin to update sliver z-order tests (flutter/tests#456) 2025-04-17 43759233+kenzieschmoll@users.noreply.github.com Revert "Disable flutter_devtools.test" (flutter/tests#455) 2025-04-15 aam@google.com Update zulip hash to pick up version that can be analyzed cleanly. (flutter/tests#453) 2025-04-15 bkonyi@google.com Disable flutter_devtools.test (flutter/tests#452) (using the command from 5ce5251 / flutter#162763 to make the log). The two changes from 2025-04-15 had been here since db68c95 (flutter#16721), but then it looks like they were accidentally reverted earlier today by 417f47f (flutter#165596). The change from 04-17 doesn't appear to have made it here to flutter/flutter yet. The latest change just went into flutter/tests today and is why I'm making this PR. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #452 now that flutter/website#11904 has landed and updates the DevTools hash to include a skipped test (flutter/devtools#9150) that was hitting the network against the test guidelines.