Skip to content

Conversation

@goderbauer
Copy link
Member

No description provided.

@goderbauer goderbauer requested a review from hannah-hyj January 30, 2025 17:47
@goderbauer
Copy link
Member Author

FYI @Piinks

Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj merged commit f36a988 into main Jan 30, 2025
12 checks passed
@hannah-hyj hannah-hyj deleted the goderbauer-patch-1 branch January 30, 2025 18:54
victoreronmosele pushed a commit to victoreronmosele/tests that referenced this pull request Feb 5, 2025
gnprice added a commit to gnprice/flutter that referenced this pull request Feb 5, 2025
Looks like this is the first roll since this pin was introduced
in flutter#162041 / flutter#162048.

For fun and the possible convenience of the next person doing one of
these, here's the command I used to generate the log below:

    $ git log --oneline --no-decorate --format='%cs %aE %s' b4cc097.. \
        | perl -pe 's,#,flutter/tests#,g'

flutter/tests@b4cc097...6a6d096

2025-02-05 greg@zulip.com Re-land "Update Zulip tests and re-enable (flutter/tests#441)" (flutter/tests#446)
2025-01-30 goderbauer@google.com Update contact for pkg:animations (flutter/tests#447)
2025-01-24 matanlurey@users.noreply.github.com Add a PR template that explains updating `tests.version` (flutter/tests#445)
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Feb 5, 2025
Looks like this is the first roll since this pin was introduced in
#162041 / #162048.

For fun and the possible convenience of the next person doing one of
these, here's the command I used to generate the log below:

$ git log --oneline --no-decorate --format='%cs %aE %s' b4cc097.. \
        | perl -pe 's,#,flutter/tests#,g'

flutter/tests@b4cc097...6a6d096

2025-02-05 greg@zulip.com Re-land "Update Zulip tests and re-enable
(flutter/tests#441)" (flutter/tests#446)
2025-01-30 goderbauer@google.com Update contact for pkg:animations
(flutter/tests#447)
2025-01-24 matanlurey@users.noreply.github.com Add a PR template that
explains updating `tests.version` (flutter/tests#445)

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants