Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jan 13, 2025

The maintainer is OOO per @justinmc. These can be re-enabled once they return and address the issues that have been blocking other changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks requested review from TahaTesser and justinmc January 13, 2025 20:33
@Piinks Piinks mentioned this pull request Jan 13, 2025
8 tasks
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

FYI @gnprice. I'm definitely happy to work with you guys to to fix anything when you're back.

Example: flutter/flutter#143249

@auto-submit auto-submit bot merged commit 083ba54 into flutter:main Jan 13, 2025
12 checks passed
@gnprice
Copy link
Member

gnprice commented Jan 15, 2025

Sorry, was slow to catch up on things after the holidays. I've just merged Victor's update for flutter/flutter#143249 in Zulip's tests; following up at #441.

victoreronmosele pushed a commit to victoreronmosele/tests that referenced this pull request Feb 5, 2025
The maintainer is OOO per @justinmc. These can be re-enabled once they return and address the issues that have been blocking other changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants