Skip to content

Update super_editor.test #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 20, 2024
Merged

Update super_editor.test #345

auto-submit merged 1 commit into from
Feb 20, 2024

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Feb 15, 2024

Roll super_editor to a commit with the ParagraphBuilder.setDisableRoundingHack flag removed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@LongCatIsLooong LongCatIsLooong mentioned this pull request Feb 15, 2024
Merged
8 tasks
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 20, 2024
@LongCatIsLooong
Avoid applying partial dartfixes on CI (#143551)
174e586 
Unblocks flutter/tests#345

Add `bulkApply: false` to partial fixes so they don't automatically get applied on registered tests.
gspencergoog
gspencergoog approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@auto-submit auto-submit bot merged commit f230ab9 into main Feb 20, 2024
@auto-submit auto-submit bot deleted the LongCatIsLooong-patch-1 branch February 20, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @gspencergoog