Skip to content

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Dec 1, 2023

Some tests in macos_ui are not hermetic. This PR disabled them in order to unblock the Flutter tree.

Issue filed: macosui/macos_ui#499

jonahwilliams
jonahwilliams previously approved these changes Dec 1, 2023
Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matanlurey
matanlurey previously approved these changes Dec 1, 2023
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 1, 2023

auto label is removed for flutter/tests/317, due to - The status or check suite windows_tests (shard 1 of 5, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@mdebbar mdebbar dismissed stale reviews from matanlurey and jonahwilliams via 9bc99cb December 1, 2023 18:06
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 1, 2023

auto label is removed for flutter/tests/317, due to - The status or check suite windows_tests (shard 3 of 5, 2) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit label Dec 1, 2023
Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit 2e742c6 into main Dec 1, 2023
@auto-submit auto-submit bot deleted the disable_macos_ui branch December 1, 2023 18:49
mdebbar added a commit to flutter/flutter that referenced this pull request Dec 1, 2023
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
XilaiZhang pushed a commit to flutter/flutter that referenced this pull request Dec 2, 2023
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
XilaiZhang pushed a commit to flutter/flutter that referenced this pull request Dec 4, 2023
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
XilaiZhang pushed a commit to flutter/flutter that referenced this pull request Dec 4, 2023
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
XilaiZhang pushed a commit to flutter/flutter that referenced this pull request Dec 5, 2023
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
The tree is red due a non-hermetic customer test from `macos_ui`. The
test was disabled in flutter/tests#317 and an
issue was filed at macosui/macos_ui#499.

We need this empty commit in order to re-run CI with the latest
https://github.com/flutter/tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants