-
Notifications
You must be signed in to change notification settings - Fork 126
Disable non-hermetic tests of macos_ui #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
matanlurey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
auto label is removed for flutter/tests/317, due to - The status or check suite windows_tests (shard 1 of 5, 0) has failed. Please fix the issues identified (or deflake) before re-applying this label. |
9bc99cb
|
auto label is removed for flutter/tests/317, due to - The status or check suite windows_tests (shard 3 of 5, 2) has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
The tree is red due a non-hermetic customer test from `macos_ui`. The test was disabled in flutter/tests#317 and an issue was filed at macosui/macos_ui#499. We need this empty commit in order to re-run CI with the latest https://github.com/flutter/tests.
Some tests in
macos_uiare not hermetic. This PR disabled them in order to unblock the Flutter tree.Issue filed: macosui/macos_ui#499