Skip to content

Disable flutter_reactive_ble test #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 28, 2023
Merged

Disable flutter_reactive_ble test #291

auto-submit merged 1 commit into from
Aug 28, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Aug 28, 2023 •
edited
Loading

Temporarily disable flutter_reactive_ble test while investigating flutter/flutter#133483.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino
christopherfujino approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth mentioned this pull request Aug 28, 2023
Merged
8 tasks
@auto-submit auto-submit bot merged commit bee005f into flutter:main Aug 28, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 28, 2023
@vashworth
Empty commit to re-trigger tests (#133495)
e7fc5a6 
An empty commit to re-trigger tests for flutter/tests#291
MohammedTarigg pushed a commit to MohammedTarigg/flutter that referenced this pull request Nov 21, 2025
@vashworth @MohammedTarigg
Empty commit to re-trigger tests (flutter#133495)
c97a553 
An empty commit to re-trigger tests for flutter/tests#291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @christopherfujino