Revert "[camera]: Bump robolectric from 4.5 to 4.8.2 in /packages/camera/camera_android/android" #6385
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is a full revert to fix the tree. Removing "needs tests" label. |
|
(Also, if there's a fix-forward that allows us to not revert this, feel free to close this) |
|
Ugh, none of the Cirrus presubmits ran for the PR that updated this. And since they never ran, they didn't fail, so everything was green :( |
…ckages/camera/camera_android/android (flutter#6329)" (flutter/plugins#6385)
This is correct, I think it's what allowed the bug to creep in. (A little bit unfortunate). |
…era/camera_android/android (flutter#6329)" (flutter#6385) This reverts commit c04e5a3.
…era/camera_android/android (flutter#6329)" (flutter#6385) This reverts commit c04e5a3.
Reverts #6329
camera_android unit tests seem to be failing pretty consistently in main.
Attempting to restore the tree by reverting the PR above.