-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Configure dependabot to ignore minor versions #6355
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question. Thanks for slogging through this!
.github/dependabot.yml
Outdated
| - dependency-name: "androidx.test:*" | ||
| update-types: ["version-update:semver-minor"] | ||
| - dependency-name: "org.robolectric:*" | ||
| update-types: ["version-update:semver-minor"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to suggest that we use anchors and aliases to cut down on all of this boilerplate, but whomp whomp 🙁
.github/dependabot.yml
Outdated
| open-pull-requests-limit: 10 | ||
| ignore: | ||
| - dependency-name: "com.android.tools.build:gradle" | ||
| update-types: ["version-update:semver-minor"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if ignoring semver-minor automatically ignores semver-patch as well, or do we have to list both? I would hope it would, but I didn't see anything in the docs that would indicate either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs are unclear, but I now think that maybe they wouldn't, so I'll go ahead and add it.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Addresses flutter/flutter#109628.
Ignores minor version and patch updates for all example apps and of the following dependencies in the plugins: the Android Gradle plugin, junit, mockito, androidx.test, and robolectric.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.