Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[camera_web] Update camera_web to support Dart's new async requestFullscreen API #4694

Merged
jason-simmons merged 1 commit into from
Jan 26, 2022
Merged

[camera_web] Update camera_web to support Dart's new async requestFullscreen API #4694

jason-simmons merged 1 commit into from
Jan 26, 2022

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jan 25, 2022 •
edited
Loading

No version change: No change to plugin functionality

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 25, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jason-simmons jason-simmons force-pushed the request_fullscreen branch 2 times, most recently from 6ba612a to 1a49c79 Compare January 25, 2022 22:14
@jason-simmons jason-simmons changed the title Update camera_web to support Dart's new async requestFullscreen API [camera_web] Update camera_web to support Dart's new async requestFullscreen API Jan 25, 2022
@gaaclarke
Copy link
Member

gaaclarke commented Jan 26, 2022

fyi the publishable step won't pick up the change in a commit message without pushing to the branch

@Hixie
Copy link
Contributor

Hixie commented Jan 26, 2022

test-exempt: refactor with no semantic change

Hixie
Hixie approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jan 26, 2022

Please do add a changelog entry since you are changing code; it makes it easier to pinpoint issues if there's some unintended behavioral change.

@jason-simmons
[camera_web] Update camera_web to support Dart's new async requestFul…
ee06d0b 
…lscreen API

No version change: No change to plugin functionality
@jason-simmons
Copy link
Member Author

jason-simmons commented Jan 26, 2022

Updated packages/camera/camera_web/CHANGELOG.md

@jason-simmons jason-simmons merged commit 01b0a8f into flutter:main Jan 26, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 26, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 26, 2022
@engine-flutter-autoroll
01b0a8f [camera_web] Update camera_web to support Dart's new async re…
ebd17e3 
…questFullscreen API (flutter/plugins#4694)
@ditman
Copy link
Member

ditman commented Jan 27, 2022

/cc @bselwe FYI!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

2 more reviewers

@Hixie Hixie Hixie approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests p: camera platform-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jason-simmons @gaaclarke @Hixie @stuartmorgan-g @ditman