Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Move test packages from dependencies to dev_dependencies #4231

Merged
fluttergithubbot merged 3 commits into from
Aug 15, 2021
Merged

Move test packages from dependencies to dev_dependencies #4231

fluttergithubbot merged 3 commits into from
Aug 15, 2021

Conversation

@nt4f04uNd
Copy link
Member

@nt4f04uNd nt4f04uNd commented Aug 11, 2021 •
edited
Loading

Part of flutter/flutter#86894, except for video_player_platform_interface, see flutter/flutter#86894 (comment)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@nt4f04uNd nt4f04uNd marked this pull request as draft August 11, 2021 13:23
@nt4f04uNd nt4f04uNd marked this pull request as ready for review August 11, 2021 16:13
@Hixie
Copy link
Contributor

Hixie commented Aug 11, 2021

test-exempt: build configuration refactor with no semantic change

stuartmorgan-g
stuartmorgan-g suggested changes Aug 14, 2021
View reviewed changes
stuartmorgan-g
stuartmorgan-g approved these changes Aug 14, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Aug 14, 2021
@fluttergithubbot fluttergithubbot merged commit 99c5f61 into flutter:master Aug 15, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 15, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2021
@engine-flutter-autoroll
99c5f61 Move test packages from dependencies to dev_dependencies (f…
27106da 
…lutter/plugins#4231)
@nt4f04uNd nt4f04uNd deleted the test-dep branch August 15, 2021 18:32
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Aug 15, 2021
@engine-flutter-autoroll
99c5f61 Move test packages from dependencies to dev_dependencies (f…
06be7e5 
…lutter/plugins#4231) (#88244)
blasten pushed a commit to blasten/flutter that referenced this pull request Aug 19, 2021
@engine-flutter-autoroll
99c5f61 Move test packages from dependencies to dev_dependencies (f…
1e0c5d3 
…lutter/plugins#4231) (flutter#88244)
@xster xster mentioned this pull request Aug 23, 2021
Closed
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@nt4f04uNd @fotiDim
Move test packages from dependencies to dev_dependencies (flutter…
b5308d7 
…#4231)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@nt4f04uNd @amantoux
Move test packages from dependencies to dev_dependencies (flutter…
9abb9af 
…#4231)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Dec 11, 2021
@nt4f04uNd @amantoux
Move test packages from dependencies to dev_dependencies (flutter…
9b6b4a8 
…#4231)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@LHLL LHLL Awaiting requested review from LHLL

1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: in_app_purchase p: video_player platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nt4f04uNd @Hixie @stuartmorgan-g @fluttergithubbot