Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Switch to new analysis options #3755

Merged
stuartmorgan-g merged 8 commits into from
Mar 31, 2021
Merged

[path_provider] Switch to new analysis options #3755

stuartmorgan-g merged 8 commits into from
Mar 31, 2021

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Mar 25, 2021

Removes the override to use the legacy analysis, and fixes all resulting issues.

Part of flutter/flutter#76229

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Mar 25, 2021
@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 30, 2021
@fluttergithubbot
Copy link

fluttergithubbot commented Mar 30, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_all_plugins_apk has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_all_plugins_web has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_all_plugins_linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_all_plugins_ipa has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite build_all_plugins_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 30, 2021
@stuartmorgan-g stuartmorgan-g merged commit febc3e3 into flutter:master Mar 31, 2021
@stuartmorgan-g stuartmorgan-g deleted the path-provider-analysis-align branch March 31, 2021 19:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 31, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 31, 2021
@engine-flutter-autoroll
febc3e3 [path_provider] Switch to new analysis options (flutter/plugi…
86fcd69 
…ns#3755)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Mar 31, 2021
@engine-flutter-autoroll
febc3e3 [path_provider] Switch to new analysis options (flutter/plugi…
6fd2dcf 
…ns#3755) (#79476)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@stuartmorgan-g @fotiDim
[path_provider] Switch to new analysis options (flutter#3755)
8df5250 
Removes the override to use the legacy analysis, and fixes all resulting issues.

Part of flutter/flutter#76229
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: path_provider platform-linux platform-macos platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @fluttergithubbot @blasten