Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 23, 2021

Forked from #3728 to fix ci.

This moves the in_app_purchase app facing package into a new sub-folder (in_app_purchage/in_app_purchase)
to prepare for the migration to federated architecture.

Note: since this only changes the directory layout of the project but doesn't change anything in the plugin itself I decided not to update the version number in the pubspec.yaml and/or CHANGELOG.md.

Implements part of issue flutter/flutter#78525

@cyanglaz cyanglaz requested a review from mvanbeusekom March 24, 2021 18:54
@cyanglaz cyanglaz marked this pull request as ready for review March 24, 2021 18:55
@cyanglaz cyanglaz requested a review from LHLL as a code owner March 24, 2021 18:55
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for helping out @cyanglaz

@cyanglaz cyanglaz changed the title [in app purchase] create sub folder [in_app_purchase] create sub folder Mar 24, 2021
@cyanglaz cyanglaz added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Mar 24, 2021
@cyanglaz cyanglaz merged commit e73402d into flutter:master Mar 24, 2021
@cyanglaz cyanglaz deleted the iap_sub_folder branch March 24, 2021 23:19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: in_app_purchase platform-android platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants