This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[video_player_platform_interface] add http headers #3702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
stuartmorgan-g
suggested changes
Mar 23, 2021
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just one small change, otherwise looks good.
|
|
||
| /// HTTP headers used for the request to the [uri]. | ||
| /// Only for [DataSourceType.network] videos. | ||
| Map<String, String>? httpHeaders; |
Contributor
There was a problem hiding this comment.
Non-nullable with empty default; see comment in other review.
...ages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2021
|
This seems to have no |
Contributor
Author
|
@aliyazdi75 yes, because this PR is just platform_interface part of #3671 which isn't merged yet |
|
@PiN73 oh, ok. They must be separated, for a PR? |
Contributor
Author
|
@aliyazdi75 yes, as described in here. In short, the reason is that video_player depends on video_player_platform_interface, new version of which must be published to pub.dev first |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of #3671 and includes changes only in
video_player_platform_interfacepackage, as required in CONTRIBUTING.md