This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[image_picker] Updated README.md with new example #3044
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cyanglaz All checks are green! |
cyanglaz
reviewed
Sep 18, 2020
Contributor
Author
|
Could someone please help me understand why the Cirrus CI / build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 check is failing? @matthew-carroll @cyanglaz |
Contributor
|
@hs2361 looks like an infra flake. I triggered a re-run. |
Contributor
|
@hs2361 The diff looks a little strange. Could you rebase? |
New example code for image_picker.dart plugin as per flutter/flutter#65914
Contributor
Author
|
Actually what happened was that another version got released before I could make the changes. I had to rebase to the master branch, which is why the diff is very strange. |
cyanglaz
approved these changes
Sep 20, 2020
Contributor
cyanglaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danielroek
pushed a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Oct 1, 2020
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New example code for image_picker.dart plugin as per flutter/flutter#65914
Description
Added new example code to the README.md file for the image_picker.dart plugin which was earlier throwing an error when the image was not selected.
Related Issues
Resolves flutter/flutter#65914
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?