Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@hs2361
Copy link
Contributor

@hs2361 hs2361 commented Sep 17, 2020

New example code for image_picker.dart plugin as per flutter/flutter#65914

Description

Added new example code to the README.md file for the image_picker.dart plugin which was earlier throwing an error when the image was not selected.

Related Issues

Resolves flutter/flutter#65914

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@hs2361
Copy link
Contributor Author

hs2361 commented Sep 17, 2020

@cyanglaz All checks are green!

@hs2361
Copy link
Contributor Author

hs2361 commented Sep 19, 2020

Could someone please help me understand why the Cirrus CI / build-ipas+drive-examples CHANNEL:stable PLUGIN_SHARDING:--shardIndex 3 --shardCount 4 check is failing? @matthew-carroll @cyanglaz

@cyanglaz
Copy link
Contributor

@hs2361 looks like an infra flake. I triggered a re-run.

@cyanglaz
Copy link
Contributor

@hs2361 The diff looks a little strange. Could you rebase?

@hs2361
Copy link
Contributor Author

hs2361 commented Sep 20, 2020

Actually what happened was that another version got released before I could make the changes. I had to rebase to the master branch, which is why the diff is very strange.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz merged commit 127344f into flutter:master Sep 21, 2020
danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[image_picker ]The minimal code sample could be improved to handle when no image is picked

3 participants