Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@TahaTesser
Copy link
Member

Description

fixed url_launcher link in url_launcher_web README. It was being sent to 404 not found

Related Issues

Fixes flutter/flutter#57819

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

TahaTesser and others added 2 commits August 13, 2020 17:19
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to +1 bump the version and CHANGELOG so we can republish to pub.

@TahaTesser
Copy link
Member Author

@ditman I committed the changes you suggested.

@ditman ditman self-requested a review August 14, 2020 15:56
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @TahaTesser!!

@ditman ditman merged commit 6f6b786 into flutter:master Aug 14, 2020
@TahaTesser
Copy link
Member Author

@ditman
#2793 this can also be closed

@ditman
Copy link
Member

ditman commented Aug 14, 2020

Merged and published 0.1.2+1

jarrodcolburn pushed a commit to jarrodcolburn/plugins that referenced this pull request Aug 20, 2020
Co-authored-by: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com>
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Co-authored-by: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com>
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Co-authored-by: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[url_launcher_web] fix broken url in the README.md

4 participants