This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
fixed url_launcher link in url_launcher_web README #2932
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed url_launcher link in url_launcher_web README
ditman
suggested changes
Aug 13, 2020
Member
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we need to +1 bump the version and CHANGELOG so we can republish to pub.
Update version and CHANGELOG
Member
Author
|
@ditman I committed the changes you suggested. |
ditman
approved these changes
Aug 14, 2020
Member
ditman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @TahaTesser!!
Member
Author
Member
|
Merged and published 0.1.2+1 |
jarrodcolburn
pushed a commit
to jarrodcolburn/plugins
that referenced
this pull request
Aug 20, 2020
Co-authored-by: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com>
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
Co-authored-by: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com>
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Co-authored-by: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed url_launcher link in url_launcher_web README. It was being sent to 404 not found
Related Issues
Fixes flutter/flutter#57819
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?