[shared_preferences] Remove duplicate integration test #9368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accidentally enteded up with two identical, but differently named, Android integration test harness files in `shared_preferences`, causing CI to run the integration tests twice. This removes the MainActivityTest.java version, leaving the better-named FlutterActivityTest.java (there is no MainActivity in the app, it uses FlutterActivity directly). Fixes flutter/flutter#162266
tarrinneal
approved these changes
Jun 3, 2025
Collaborator
Author
|
Verified that CI is still showing that the integration tests are run—but only once now, as desired. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2025
flutter/packages@1765c95...2bac766 2025-06-03 r.masarovic@gmail.com [in_app_purchase_android] GooglePlayPurchaseParam add possibility set selected offerToken (flutter/packages#8452) 2025-06-03 github@alexv525.com [camera] 🐛 Fix toggles overflow in the camera example (flutter/packages#9274) 2025-06-03 stuartmorgan@google.com [shared_preferences] Remove duplicate integration test (flutter/packages#9368) 2025-06-03 sokolovskyi.konstantin@gmail.com [pointer_interceptor_web] Fix unresponsive input above PointerInterceptor on Safari and Firefox. (flutter/packages#9362) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
We accidentally enteded up with two identical, but differently named, Android integration test harness files in `shared_preferences`, causing CI to run the integration tests twice. This removes the MainActivityTest.java version, leaving the better-named FlutterActivityTest.java (there is no MainActivity in the app, it uses FlutterActivity directly). Fixes flutter/flutter#162266 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally enteded up with two identical, but differently named, Android integration test harness files in
shared_preferences, causing CI to run the integration tests twice. This removes the MainActivityTest.java version, leaving the better-named FlutterActivityTest.java (there is no MainActivity in the app, it uses FlutterActivity directly).Fixes flutter/flutter#162266
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3