[ci] Add LUCI web platform tests #4391
Conversation
ce65413 to
d57cd74
Compare
|
@ditman FYI on the new |
.ci.yaml
Outdated
| recipe: packages/packages | ||
| timeout: 60 | ||
| properties: | ||
| add_recipes_cq: "true" |
There was a problem hiding this comment.
I am wondering if we want to enforce these targets in the recipes CQ. To me, existing packages targets (with add_recipes_cq: true) should be enough to cover recipes change. I would suggest we skip this property here. This way, test specific regression will not block recipes CI.
There was a problem hiding this comment.
I can remove it.
For my future reference, what's the criteria for add_recipes_cq? Is it just a judgement call about whether the test depends on some aspect of the recipe that's not already covered?
There was a problem hiding this comment.
Yes, exactly. Since all these packages targets share the same recipes, and it's not necessary to enable all targets from recipes side.
| properties: | ||
| add_recipes_cq: "true" | ||
| target_file: web_platform_tests.yaml | ||
| cores: "32" |
There was a problem hiding this comment.
Is this necessary for these targets?
There was a problem hiding this comment.
These were in the heavy workload in Cirrus, and even then needed to be sharded. I've been mapping heavy workload to 32 cores based on our previous discussion.
If there's a good way to analyze runs after the fact I'm happy to tune this later based on actual usage.
ditman
left a comment
There was a problem hiding this comment.
This LGTM, make CI and @keyonghan happy, and ship it!
|
auto label is removed for flutter/packages, pr: 4391, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 0 --shardCount 8 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@771ec9b...9bcf4bf 2023-07-07 stuartmorgan@google.com [ci] Add LUCI web platform tests (flutter/packages#4391) 2023-07-07 stuartmorgan@google.com [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271) 2023-07-07 stuartmorgan@google.com [ci] Add partial LUCI version of repo_checks (flutter/packages#4389) 2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302) 2023-07-06 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354) 2023-07-06 stuartmorgan@google.com [local_auth] Update Windows Pigeon version (flutter/packages#4388) 2023-07-06 77553258+victorsanni@users.noreply.github.com [url_launcher] Remove nested third_party safari checker (flutter/packages#4330) 2023-07-06 stuartmorgan@google.com [ci] Add partial LUCI Android platform tests (flutter/packages#4381) 2023-07-06 stuartmorgan@google.com [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386) 2023-07-06 47866232+chunhtai@users.noreply.github.com [go_router] Exposes package-level privates (flutter/packages#4380) 2023-07-06 stuartmorgan@google.com [file_selector] Update to 1.0 (flutter/packages#4362) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
I just noticed that this PR added a |
|
I wonder how I did that. I'll clean it up in the next LUCI PR. |
Adds web platform tests for LUCI in bringup mode.
The Cirrus version of the test starts
chromedriverat the beginning and just leaves it running, which is fine since it's a fresh docker image each run. For LUCI we don't want that behavior though, so instead this adds tooling support for running chromedriver as part of running the integration tests, controllable with a flag. This will also be useful for running locally.Part of flutter/flutter#114373