[pigeon] Remove version from most test code #3660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a global option to prevent the Pigeon version from being output in the generated code warning, and enables it when generating the files that are validated by CI. Since we know the files are always up to date due to the CI checks, having the version of every file change in every PR just adds noise. Test files that haven't been consolidated into the new testing framework (mock_handler_tester, flutter_null_safe_unit_tests) still have the version for now, since they aren't yet validated by CI.
Collaborator
Author
|
Overriding version and changelog; while there are production code changes here, they should be a no-op to all clients, and aren't intended for general use (although technically anyone using Pigeon as a library could set this), so there's no value in having it be its own release. |
tarrinneal
approved these changes
Apr 7, 2023
Contributor
tarrinneal
left a comment
There was a problem hiding this comment.
How am I going to make my butter if we stop all this churn?
| bool suppressVersion = false, | ||
| }) async { | ||
| return Pigeon.runWithOptions(PigeonOptions( | ||
| // Temporarily suppress the version output via the global flag if requseted. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
[pigeon] Remove version from most test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a global option to prevent the Pigeon version from being output in the generated code warning, and enables it when generating the files that are validated by CI. Since we know the files are always up to date due to the CI checks, having the version of every file change in every PR just adds noise.
Test files that haven't been consolidated into the new testing framework (mock_handler_tester, flutter_null_safe_unit_tests) still have the version for now, since they aren't yet validated by CI.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).