Skip to content

[pigeon] Fix Obj-C signature mismatch #3657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Apr 7, 2023
Merged

[pigeon] Fix Obj-C signature mismatch #3657

auto-submit merged 1 commit into from
Apr 7, 2023

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Apr 6, 2023

Updates the definition of the *GetCodec function to have a void parameter list, matching its declaration, to fix a new warning in clang 15.

Fixes flutter/flutter#124343

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
[pigeon] Fix Obj-C signature mismatch
3f71a28 
Updates the definition of the `*GetCodec` function to have a `void`
parameter list, matching its declaration, to fix a new warning in clang
15.

Fixes flutter/flutter#124343
@stuartmorgan-g stuartmorgan-g requested a review from jmagman April 6, 2023 20:25
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2023
@auto-submit auto-submit bot merged commit 4914c64 into flutter:main Apr 7, 2023
jmagman
jmagman reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stuartmorgan!

@stuartmorgan-g stuartmorgan-g deleted the pigeon-objc-void-prototype branch April 7, 2023 02:34
@stuartmorgan-g
Copy link
Collaborator Author

stuartmorgan-g commented Apr 7, 2023

I can do Obj-C Pigeon updates in flutter/packages tomorrow to make sure we won't be broken by future Xcode updates in that repo.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
4914c64 [pigeon] Fix Obj-C signature mismatch (flutter/packages#3657)
55f995f
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@stuartmorgan-g @nploi
[pigeon] Fix Obj-C signature mismatch (flutter#3657)
a606d1b 
[pigeon] Fix Obj-C signature mismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman left review comments

@tarrinneal tarrinneal tarrinneal approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon platform-android platform-ios platform-macos platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pigeon generated Objective-C code produces warning A function declaration without a prototype is deprecated in all versions of C

3 participants

@stuartmorgan-g @jmagman @tarrinneal