-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[go_router] Added initialExtra param to GoRouter
#3472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
initialExtra param to **GoRouter**initialExtra param to *GoRouter*
initialExtra param to *GoRouter*initialExtra param to GoRouter
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
It looks like you need to run format and also bump the package version |
@chunhtai Done |
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/go_router/CHANGELOG.md
Outdated
| @@ -1,8 +1,9 @@ | |||
| ## NEXT | |||
| ## 6.2.1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be 6.3.0
packages/go_router/pubspec.yaml
Outdated
| description: A declarative router for Flutter based on Navigation 2 supporting | ||
| deep linking, data-driven routes and more | ||
| version: 6.2.0 | ||
| version: 6.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
hannah-hyj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # packages/go_router/CHANGELOG.md
# Conflicts: # packages/go_router/CHANGELOG.md
# Conflicts: # packages/go_router/CHANGELOG.md # packages/go_router/pubspec.yaml
[go_router] Added `initialExtra` param to GoRouter
Adds
initialExtraparam that can use to send extra object alongsideinitialLocation.Fixes flutter/flutter#122780
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.