Skip to content

Conversation

@sarbagyastha
Copy link
Contributor

Adds initialExtra param that can use to send extra object alongside initialLocation.

Fixes flutter/flutter#122780

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sarbagyastha sarbagyastha requested a review from chunhtai as a code owner March 16, 2023 05:12
@sarbagyastha sarbagyastha changed the title [go_router] Added initialExtra param to **GoRouter** [go_router] Added initialExtra param to *GoRouter* Mar 16, 2023
@sarbagyastha sarbagyastha changed the title [go_router] Added initialExtra param to *GoRouter* [go_router] Added initialExtra param to GoRouter Mar 16, 2023
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Contributor

It looks like you need to run format and also bump the package version

@sarbagyastha
Copy link
Contributor Author

It looks like you need to run format and also bump the package version

@chunhtai Done

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,8 +1,9 @@
## NEXT
## 6.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be 6.3.0

description: A declarative router for Flutter based on Navigation 2 supporting
deep linking, data-driven routes and more
version: 6.2.0
version: 6.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@chunhtai chunhtai requested a review from hannah-hyj March 16, 2023 19:10
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[go_router] Added `initialExtra` param to GoRouter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router] Support passing extra object alongside initialLocation while creating GoRouter

3 participants