[image_picker] moves Android 13 image picker to options #3370
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Rather than have this Android-specific option in all of the APIs, I would rather we restrict this to the Android package. Since I doubt anyone is going to want different versions for different calls within the same app, the simplest option for clients would be a class-level setting, which we can put on the Android implementation in this case.
See https://pub.dev/packages/google_maps_flutter_android#display-mode for an example of what a platform class option looks like.
This is very helpful, thank you |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks, this looks good at the Android package level. I left a comment about the wrapper API in the app-facing package, which we should remove. I apparently picked the worst example to point you to without realizing it :(
Unfortunately the implementation-package-specific APIs are still relatively new territory in our plugin development, so things aren't as consistent as they could be yet.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with some nits on the README.
packages/image_picker/image_picker_android/example/lib/main.dart
Outdated
Show resolved
Hide resolved
[image_picker] moves Android 13 image picker to options
Since the newest Android image picker doesn't yet support cloud files, I've moved it to an optional parameter for now.
This will allow users to maintain their cloud access while still allowing the people who want to use the new picker to do so as well.
fixes flutter/flutter#121744
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.