Skip to content

[analysis_options] sync lint rules with flutter/flutter#2495

Merged
auto-submit[bot] merged 8 commits into
flutter:mainfrom
goderbauer:syncLints
Aug 25, 2022
Merged

[analysis_options] sync lint rules with flutter/flutter#2495
auto-submit[bot] merged 8 commits into
flutter:mainfrom
goderbauer:syncLints

Conversation

@goderbauer

@goderbauer goderbauer commented Aug 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Syncs the lint configuration from the master file in the flutter/flutter repository over to this repository and fixes all resulting violations.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@goderbauer goderbauer changed the title Sync lints [analysis_options] sync lint rules with flutter/flutter Aug 24, 2022
@goderbauer goderbauer marked this pull request as ready for review August 24, 2022 16:31
@goderbauer

goderbauer commented Aug 24, 2022

Copy link
Copy Markdown
Member Author

@stuartmorgan Is there anything special I need to do for packages that have a "NEXT" changelog entry? The check is not happy with what I did: https://cirrus-ci.com/task/5907580605169664

stuartmorgan-g
stuartmorgan-g requested changes Aug 24, 2022
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this has been on my TODO list for quite a while!

Just some small things here and there.

Comment thread packages/cross_file/pubspec.yaml Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test-only change doesn't need a version bump.

Comment thread packages/flutter_markdown/example/lib/demos/basic_markdown_demo.dart Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a TODO to restructure it?

Comment thread packages/flutter_markdown/example/lib/demos/centered_header_demo.dart Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same throughout.

Comment thread packages/flutter_markdown/lib/src/builder.dart Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems problematic, and like something that should have a bug and a TODO.

Comment thread packages/go_router/CHANGELOG.md Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has production code changes, so should be versioned.

Comment thread packages/palette_generator/CHANGELOG.md Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be versioned.

Comment thread packages/palette_generator/palette_generator.iml Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just delete this file.

Comment thread packages/pigeon/lib/objc_generator.dart Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really long; let's use a local variable and interpolate that variable instead.

Comment thread packages/rfw/CHANGELOG.md Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be versioned.

Comment thread packages/standard_message_codec/example/lib/readme_excerpts.dart Outdated

@stuartmorgan-g stuartmorgan-g Aug 24, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at the file level so this doesn't show up in the excerpt (once the excerpt annotations are fixed).

@stuartmorgan-g

stuartmorgan-g commented Aug 24, 2022

Copy link
Copy Markdown
Collaborator

@stuartmorgan Is there anything special I need to do for packages that have a "NEXT" changelog entry? The check is not happy with what I did: https://cirrus-ci.com/task/5907580605169664

You can't use NEXT if you are changing client-affecting code without overriding the check, because of repo policy. If there are cases you are absolutely sure shouldn't be versioned, we can override them, but at least some of them should be.

This was referenced Aug 24, 2022
Closed
Closed
Closed
@goderbauer

goderbauer commented Aug 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

This is ready for another review.

For the packages cross_file and standard_message_codec I'd like to get an exception for versioning and changeloging as there are no meaningful changes to production code to these two packages.

Scratch that, no exception needed.

stuartmorgan-g
stuartmorgan-g approved these changes Aug 25, 2022
View reviewed changes

@stuartmorgan-g stuartmorgan-g left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit. Thanks again!

Comment thread packages/cross_file/CHANGELOG.md Outdated

@stuartmorgan-g stuartmorgan-g Aug 25, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Fixes

Per style guide.

Comment thread packages/standard_message_codec/CHANGELOG.md Outdated

@stuartmorgan-g stuartmorgan-g Aug 25, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@auto-submit

auto-submit Bot commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@auto-submit

auto-submit Bot commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2022
@auto-submit auto-submit Bot merged commit 88585ef into flutter:main Aug 25, 2022
@goderbauer goderbauer deleted the syncLints branch August 25, 2022 17:00
@goderbauer goderbauer mentioned this pull request Aug 30, 2022
Merged
11 tasks
@Piinks Piinks mentioned this pull request Aug 30, 2022
Merged
11 tasks
@gazreese gazreese mentioned this pull request Feb 18, 2026
Open
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@goderbauer
[analysis_options] sync lint rules with flutter/flutter (flutter#2495)
cf4b109
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@goderbauer
[analysis_options] sync lint rules with flutter/flutter (flutter#2495)
e72daab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: animations p: cross_file p: extension_google_sign_in_as_googleapis_auth p: flutter_image p: flutter_markdown p: fuchsia_ctl p: go_router_builder p: go_router p: imitation_game p: metrics_center p: multicast_dns p: palette_generator p: pigeon p: pointer_interceptor p: rfw Remote Flutter Widgets p: web_benchmarks p: xdg_directories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @stuartmorgan-g