Skip to content

[ci] Allow mustache_template deps#11882

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:allow-mustache-template
Jun 10, 2026
Merged

[ci] Allow mustache_template deps#11882
auto-submit[bot] merged 1 commit into
flutter:mainfrom
stuartmorgan-g:allow-mustache-template

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

mustache_template was moved to flutter/core-packages, but I didn't realize that google_fonts uses it in its generator. Now that it's not in-repo, that requires an explicit allowance so that pubspec validation passes.

`mustache_template` was moved to flutter/core-packages, but I didn't
realize that `google_fonts` uses it in its generator. Now that it's not
in-repo, that requires an explicit allowance so that pubspec validation
passes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the "mustache_template" package to the allowed dependencies list in ".repo_tool_config.yaml". There are no review comments, and I have no feedback to provide.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

This is blocking the roller (and any other PR that runs all tests).

There's an interesting edge case here where removing a package doesn't trigger full-repo tests, so this wasn't caught in presubmit (or even postsubmit) for my PR.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 10, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

test-exempt: fixes a broken CI test (validate of google_fonts)

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2026
@auto-submit auto-submit Bot merged commit af3dde8 into flutter:main Jun 10, 2026
86 of 87 checks passed
andywolff pushed a commit to bdero/flutter that referenced this pull request Jun 12, 2026
…r#187928)

flutter/packages@1b56cde...b78ad83

2026-06-12 48776784+mackings@users.noreply.github.com [camera] Fix web
facingMode capability handling (flutter/packages#11728)
2026-06-11 engine-flutter-autoroll@skia.org Roll Flutter from
c0a1129 to 8bdce07 (13 revisions) (flutter/packages#11885)
2026-06-11 github.com@h-h.win [pigeon] make swift enum CaseIterable
(flutter/packages#11702)
2026-06-11 engine-flutter-autoroll@skia.org Roll Flutter from
66aaa9a to c0a1129 (17 revisions) (flutter/packages#11881)
2026-06-10 stuartmorgan@google.com [ci] Allow mustache_template deps
(flutter/packages#11882)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy pushed a commit to via-guy/flutter that referenced this pull request Jun 26, 2026
…r#187928)

flutter/packages@1b56cde...b78ad83

2026-06-12 48776784+mackings@users.noreply.github.com [camera] Fix web
facingMode capability handling (flutter/packages#11728)
2026-06-11 engine-flutter-autoroll@skia.org Roll Flutter from
c0a1129 to 8bdce07 (13 revisions) (flutter/packages#11885)
2026-06-11 github.com@h-h.win [pigeon] make swift enum CaseIterable
(flutter/packages#11702)
2026-06-11 engine-flutter-autoroll@skia.org Roll Flutter from
66aaa9a to c0a1129 (17 revisions) (flutter/packages#11881)
2026-06-10 stuartmorgan@google.com [ci] Allow mustache_template deps
(flutter/packages#11882)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants