[video_player_web] Remove stale package:web tweaks#11820
Merged
auto-submit[bot] merged 3 commits intoJun 17, 2026
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum supported version of package:web to 1.0.0 in pubspec.yaml and updates the changelog accordingly. It also removes obsolete extension methods and setters from pkg_web_tweaks.dart that are now natively supported in the updated package version. There are no review comments, and I have no feedback to provide.
mdebbar
approved these changes
Jun 3, 2026
mdebbar
left a comment
Contributor
There was a problem hiding this comment.
Thanks for cleaning this up!
Collaborator
|
Version override: This is a behavioral no-op, so doesn't need to be published. |
pull Bot
pushed a commit
to Mattlk13/flutter
that referenced
this pull request
Jun 18, 2026
…r#188171) flutter/packages@6ce00a8...4fd05e6 2026-06-17 faheemabbas766@gmail.com [video_player_web] Remove stale package:web tweaks (flutter/packages#11820) 2026-06-17 engine-flutter-autoroll@skia.org Roll Flutter from 3a0420c to b10d0f1 (23 revisions) (flutter/packages#11928) 2026-06-17 hirotamu3@gmail.com [vector_graphics_compiler] Use Abi.current() for engine-artifact lookup on Linux ARM64 (flutter/packages#11781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jun 18, 2026
…r#188171) flutter/packages@6ce00a8...4fd05e6 2026-06-17 faheemabbas766@gmail.com [video_player_web] Remove stale package:web tweaks (flutter/packages#11820) 2026-06-17 engine-flutter-autoroll@skia.org Roll Flutter from 3a0420c to b10d0f1 (23 revisions) (flutter/packages#11928) 2026-06-17 hirotamu3@gmail.com [vector_graphics_compiler] Use Abi.current() for engine-artifact lookup on Linux ARM64 (flutter/packages#11781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
via-guy
pushed a commit
to via-guy/flutter
that referenced
this pull request
Jun 26, 2026
…r#188171) flutter/packages@6ce00a8...4fd05e6 2026-06-17 faheemabbas766@gmail.com [video_player_web] Remove stale package:web tweaks (flutter/packages#11820) 2026-06-17 engine-flutter-autoroll@skia.org Roll Flutter from 3a0420c to b10d0f1 (23 revisions) (flutter/packages#11928) 2026-06-17 hirotamu3@gmail.com [vector_graphics_compiler] Use Abi.current() for engine-artifact lookup on Linux ARM64 (flutter/packages#11781) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
rwrz
added a commit
to RealLifeGlobal/packages
that referenced
this pull request
Jun 26, 2026
Resolves video_player conflicts between the fork's custom work and upstream: - Pigeon API (video_player_instance_messages): union of the fork's ABR control (PlatformVideoQuality, getAvailableQualities/getCurrentQuality/ setMaxBitrate/setMaxResolution) and upstream's video track selection (flutter#11476: MediaSelection/Asset/NativeVideoTrackData, getVideoTracks/ selectVideoTrack). Generated .g.dart/.g.m/.g.h regenerated via pigeon. - avfoundation_video_player.dart: kept both override sets. - PlatformVideoView.java: took upstream's VideoSurfaceView fix (flutter#11416) and kept the fork's exoPlayer field used by dispose(). - pubspec.yaml (avf/web/example): kept path: dependency on the local video_player_platform_interface (fork has unpublished interface methods); took upstream version bump 2.10.0 and web: ^1.0.0. - CHANGELOG: folded the fork's backgrounding-crash fix into 2.10.0. - pkg_web_tweaks.dart: aligned with upstream (flutter#11820) to reduce divergence. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes stale
package:webhelper setters fordisablePictureInPictureanddisableRemotePlaybackfromvideo_player_web.These APIs are available directly from
package:web1.0.0, so this updates the package's minimum supportedwebversion to>=1.0.0 <2.0.0. ThecontrolsListhelper is intentionally kept becausepackage:webdoes not expose it yet.Fixes flutter/flutter#187430
Tests
Notes
No new tests were added because this removes stale compatibility helpers and preserves the existing runtime calls. Existing package tests and lower-bound analysis pass.
The
example/integration_testsuite was not run locally because Flutter reported:Web devices are not supported for integration tests yet.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
This PR includes the required
pubspec.yamlandCHANGELOG.mdupdates. No new tests were added because this is a compatibility-helper cleanup; existing tests and lower-bound analysis pass. ↩ ↩2