-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Create flutter_template_images package #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create flutter_template_images package #118
Conversation
Contains images used in 'flutter create' templates, to avoid needing to check them into flutter/flutter where they will permanently inflate the repo size. Currently only contains the Windows app icon, since existing template icons are already part of the Flutter repository. Future template images, including changes to the existing images, should live here instead.
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
| @@ -0,0 +1,3 @@ | |||
| library flutter_template_images; | |||
|
|
|||
| // There is no source for this package, since it only exists to hold images. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i guess we need a dart file to make pub happy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually know; I decided to leave it like this because having no source felt like the kind of thing that might break later since it's such an odd thing to do. If you'd rather risk it I can try it out, it just didn't seem worth it to me. (Plus this makes things a bit more self-documenting if someone looks at the source instead of the README.)
|
looking at the app_icon.ico file on mac chrome, it looks a bit squished. no idea if that's a real problem or a bug in mac or chrome. |
Good catch; it was real. Apparently the tool I used to make it the first time warped the source image's aspect ratio to make the square icon sizes requested. I remade it differently, and it looks like the tool I used the first time wasn't doing any compression since it's now only 33kb, and that's including a larger size that I hadn't done initially, but after further investigation does seem to be recommended for modern versions of Windows. |
remove library dependency for back button
Contains images used in 'flutter create' templates, to avoid needing to
check them into flutter/flutter where they will permanently inflate the
repo size.
Currently only contains the Windows app icon, since existing template
icons are already part of the Flutter repository. Future template
images, including changes to the existing images, should live here
instead.