Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Contains images used in 'flutter create' templates, to avoid needing to
check them into flutter/flutter where they will permanently inflate the
repo size.

Currently only contains the Windows app icon, since existing template
icons are already part of the Flutter repository. Future template
images, including changes to the existing images, should live here
instead.

Contains images used in 'flutter create' templates, to avoid needing to
check them into flutter/flutter where they will permanently inflate the
repo size.

Currently only contains the Windows app icon, since existing template
icons are already part of the Flutter repository. Future template
images, including changes to the existing images, should live here
instead.
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@@ -0,0 +1,3 @@
library flutter_template_images;

// There is no source for this package, since it only exists to hold images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess we need a dart file to make pub happy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know; I decided to leave it like this because having no source felt like the kind of thing that might break later since it's such an odd thing to do. If you'd rather risk it I can try it out, it just didn't seem worth it to me. (Plus this makes things a bit more self-documenting if someone looks at the source instead of the README.)

@Hixie
Copy link
Contributor

Hixie commented Mar 17, 2020

looking at the app_icon.ico file on mac chrome, it looks a bit squished. no idea if that's a real problem or a bug in mac or chrome.

@stuartmorgan-g
Copy link
Collaborator Author

looking at the app_icon.ico file on mac chrome, it looks a bit squished. no idea if that's a real problem or a bug in mac or chrome.

Good catch; it was real. Apparently the tool I used to make it the first time warped the source image's aspect ratio to make the square icon sizes requested. I remade it differently, and it looks like the tool I used the first time wasn't doing any compression since it's now only 33kb, and that's including a larger size that I hadn't done initially, but after further investigation does seem to be recommended for modern versions of Windows.

@stuartmorgan-g stuartmorgan-g merged commit 2463514 into flutter:master Mar 17, 2020
@stuartmorgan-g stuartmorgan-g deleted the template-images-initial branch March 17, 2020 20:56
austinstoker pushed a commit to austinstoker/packages that referenced this pull request Apr 29, 2022
remove library dependency for back button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants