[google_fonts] Add missing public API documentation #10782
Merged
+46
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request adds documentation comments for public APIs in google_fonts_descriptor.dart, google_fonts_family_with_variant.dart, and google_fonts_variant.dart. It also replaces print calls with debugPrint for logging errors in google_fonts_base.dart. The package version is updated to 7.0.2 in pubspec.yaml, and the CHANGELOG.md is updated accordingly.
stuartmorgan-g
approved these changes
Jan 13, 2026
Collaborator
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with nit. Thanks!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 14, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 14, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 14, 2026
flutter/packages@eb9e1dc...98b0325 2026-01-14 magder@google.com [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 magder@google.com [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 engine-flutter-autoroll@skia.org Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 6655696+guidezpl@users.noreply.github.com [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
patrickBillingsley
pushed a commit
to patrickBillingsley/flutter
that referenced
this pull request
Jan 14, 2026
…r#180983) flutter/packages@eb9e1dc...98b0325 2026-01-14 magder@google.com [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 magder@google.com [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 engine-flutter-autoroll@skia.org Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 6655696+guidezpl@users.noreply.github.com [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ikramhasan
pushed a commit
to ikramhasan/flutter
that referenced
this pull request
Jan 15, 2026
…r#180983) flutter/packages@eb9e1dc...98b0325 2026-01-14 magder@google.com [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 magder@google.com [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 engine-flutter-autoroll@skia.org Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 6655696+guidezpl@users.noreply.github.com [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replace
printwithdebugPrint