[google_maps_flutter] Migrate Android heatmaps to Pigeon #10758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the legacy JSON serialization of heatmaps with fully typed Pigeon data. Final Android portion of flutter/flutter#117907
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the Android implementation of heatmaps from a JSON-based serialization to a type-safe approach using Pigeon. The changes are well-executed, replacing manual serialization and deserialization with generated, typed data classes for heatmaps, gradients, and weighted points. This significantly improves code quality, readability, and maintainability by leveraging the type system to prevent runtime errors. The related controllers, data conversion logic, and tests have been updated accordingly, and the overall implementation is clean and robust. No issues were found during the review.
26 tasks
reidbaker
approved these changes
Jan 15, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 16, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 16, 2026
flutter/packages@ce3afa4...c1b1183 2026-01-16 engine-flutter-autoroll@skia.org Manual roll Flutter from b45a73b to 48c2475 (3 revisions) (flutter/packages#10814) 2026-01-16 engine-flutter-autoroll@skia.org Manual roll Flutter from b45a73b to 5a2067b (4 revisions) (flutter/packages#10810) 2026-01-15 pedromassango.developer@gmail.com [url_launcher] fix: tab traversal on web (flutter/packages#10020) 2026-01-15 stuartmorgan@google.com [google_maps_flutter] Migrate Android heatmaps to Pigeon (flutter/packages#10758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the legacy JSON serialization of heatmaps with fully typed Pigeon data.
Final Android portion of flutter/flutter#117907
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3