[camera_avfoundation] Wrappers swift migration - part 5 #10641
Merged
+215
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request migrates FLTPermissionServicing and FLTCameraPermissionManager from Objective-C to Swift, following Swift conventions by removing the FLT prefix. The changes also update tests and mocks to use the new Swift classes. The migration is well-executed. I've added one suggestion to refactor the new CameraPermissionManager.swift to reduce code duplication, improving maintainability.
...foundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPermissionManager.swift
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@hellohuanlin pls take a look at this PR when you have some time |
hellohuanlin
approved these changes
Dec 22, 2025
...amera/camera_avfoundation/example/ios/RunnerTests/Mocks/MockFLTCameraPermissionManager.swift
Outdated
Show resolved
Hide resolved
...foundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPermissionManager.swift
Show resolved
Hide resolved
...foundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPermissionManager.swift
Show resolved
Hide resolved
...foundation/ios/camera_avfoundation/Sources/camera_avfoundation/CameraPermissionManager.swift
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 24, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 24, 2025
flutter/packages@5e3a766...2164da9 2025-12-23 engine-flutter-autoroll@skia.org Manual roll Flutter from 57c3f8b to 6ff7f30 (83 revisions) (flutter/packages#10674) 2025-12-23 engine-flutter-autoroll@skia.org Manual roll Flutter from d81baab to 57c3f8b (38 revisions) (flutter/packages#10671) 2025-12-23 engine-flutter-autoroll@skia.org Roll Flutter from 6e1aa82 to d81baab (47 revisions) (flutter/packages#10637) 2025-12-23 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 5 (flutter/packages#10641) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera wrappers as part of flutter/flutter#119109
This PR migrates wrappers to Swift:
FLTPermissionServicingFLTCameraPermissionManagerIn line with Swift conventions, the
FLTprefixes are removed.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3