Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cde5b36
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: daf30f8
Choose a head ref
  • 9 commits
  • 85 files changed
  • 6 contributors

Commits on Apr 29, 2026

  1. [webview_flutter] Platform implementations for getCookies #11037 (#11386

    )
    
    *List which issues are fixed by this PR. You must list at least one issue.*
    #10833 #11037 
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    khaled-0 authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    ff0189e View commit details
    Browse the repository at this point in the history
  2. [ci] Update branch management for batch release (#11575)

    based on go/batch-release-branch option 2
    
    Needs to add flutter github bot to be able to bypass branch protection first
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    chunhtai authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    624a8be View commit details
    Browse the repository at this point in the history
  3. [tool] Remove --against-pub flag (#11550)

    We haven't used `--against-pub` in CI in a very long time, and we don't expect to need it locally. We report pub versions as part of the publish step, but the source of truth for validation is the repo, not pub. This removes the flag to simplify the tool.
    stuartmorgan-g authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    e122039 View commit details
    Browse the repository at this point in the history
  4. [google_maps_flutter] Replace use of zIndex in examples and tests (#1…

    …1572)
    
    Replaces uses of the deprecated `zIndex` in examples and tests with the preferred `zIndexInt`.
    
    This doesn't change the production use of `zIndex` in google_maps_flutter_web, as that could change behavior, so should stay for now.
    stuartmorgan-g authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    5653b5a View commit details
    Browse the repository at this point in the history
  5. [webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicati…

    …onWillTerminate` (#11567)
    
    Relands #11484
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    bparrishMines authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    e212d61 View commit details
    Browse the repository at this point in the history
  6. [two_dimensional_scrollables] trailing pinned row/col for TableView (#…

    …11519)
    
    This PR implements the requested feature to allow pinning rows and columns to the trailing edges of the TableView (bottom and right in LTR). Previously, only leading pinning was supported.
    
    This implementation allows for use cases such as a "delete" button pinned to the right of every row, or a summary footer pinned to the bottom of the table.
    
       - Added trailingPinnedRowCount and trailingPinnedColumnCount to TableView.builder, TableView.list, and their associated delegates (TableCellBuilderDelegate, TableCellListDelegate).
       - Updated RenderTableViewport to calculate and track extents for trailing pinned spans. The indices for these spans are calculated from the end of the specified rowCount or columnCount.
       - Extended layoutChildSequence in RenderTableViewport to handle all 9 regions of the resulting grid (intersections of leading-pinned, regular, and trailing-pinned rows/columns).
       - Updated the paint method to correctly clip and layer trailing pinned areas, ensuring they stay at the viewport edges and that regular content scrolls underneath them correctly.
       - Adjusted maxScrollExtent calculations to account for both leading and trailing pinned extents, ensuring the scrollable area is correctly sized.
       - Updated the table alignment logic to correctly position the entire table (including pinned areas) when it is smaller than the viewport.
    
      Technical Details
    
       - Trailing pinned elements are logically positioned based on the viewport dimension minus their cumulative extent.
       - Merged cells are supported within trailing pinned areas, with safety assertions to ensure they do not span across pinned and unpinned boundaries.
       - The implementation maintains compatibility with existing leading pinning and supports various combinations of both.
    
    Fixes flutter/flutter#133238
    [Design Doc](https://docs.google.com/document/d/1TYqmQFot4TcwiddQdNW6YHeO0F_89nqTYOZOgrULJRw/edit?usp=sharing)
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Piinks authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    3b8c4cb View commit details
    Browse the repository at this point in the history
  7. [two_dimensional_scrollables] Fix mouse event loop when calling setSt…

    …ate in TableSpan.onEnter (#11606)
    
    This PR addresses a bug in TableView where calling setState (or any action that triggers a delegate rebuild) inside a TableSpan.onEnter callback would cause an infinite loop of onExit and onEnter events.
    
    The RenderTableViewport was clearing its cached _columnMetrics and _rowMetrics (_Span objects) on every delegate rebuild. Since _Span implements MouseTrackerAnnotation, and the MouseTracker identifies regions by object identity, re-creating these objects every frame caused the MouseTracker to:
       1. Trigger onExit for the old _Span object.
       2. Trigger onEnter for the new _Span object.
    
    If onEnter contained a setState call, this cycle would repeat indefinitely.
    
    Fixes flutter/flutter#147614
    
      Fix:
       - Refactored _updateRowMetrics and _updateColumnMetrics to reuse existing _Span objects when
         available.
       - Updated _Span.update to only refresh the internal configuration and layout metrics while
         maintaining the same object instance.
       - Modified layoutChildSequence to avoid clearing the metrics maps, instead allowing the update
         methods to handle stale entries.
       - Added logic to properly dispose and remove spans when the row or column count is reduced.
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    Piinks authored Apr 29, 2026
    Configuration menu
    Copy the full SHA
    c3360ac View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2026

  1. [in_app_purchase] Switch to Kotlin Pigeon (#11608)

    Replaces the Java Pigeon generator with the Kotlin Pigeon generator, and adjusts the project accordingly:
    - Adds Kotlin build setings to Gradle.
    - Updates API signatures and number handling for Kotlin/Java generator differences.
    - Adds generic Java/Kotlin compat shim to create Result objects from Java, since those haven't been added to the Pigeon generator yet.
    - Updates tests to use constructors instead of builders, since the Kotlin generator doesn't create builders.
    - Updates tests to use a fake result value, instead of mocking the Java Pigeon response object.
    
    Most of this conversion was done by Gemini; I gave it my previous "Switch to Kotlin Pigeon" PRs for context, and let it do most of the work. Once it had a passing conversion I did some manual cleanup and warning fixing.
    
    This also converts Translator.java, which does SDK<->Pigeon type conversion, to Kotlin, per discussion in the linked issue:
    - I used Android Studio's auto-converter.
    - I did some manual cleanup (e.g., fixing nullability where it assumed nullable because the Java wasn't annotated, simplifying some switch return statements).
    - I added parameter names to all the constructors, so it's easy to see that the params are being passed correctly in review both now and in future changes.
    - I had Gemini do a pass over it to make the Kotlin simpler or more idiomatic. The big improvement was it replacing a bunch of manual list construction with `map`s.
    - Removed `currencyCodeFromSymbol`, which has been dead code for years.
    
    These steps are separate commits in case it's useful to review them separately
    
    Fixes flutter/flutter#185545
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    stuartmorgan-g authored Apr 30, 2026
    Configuration menu
    Copy the full SHA
    47cfea4 View commit details
    Browse the repository at this point in the history
  2. [url_launcher_web] Re-enable flaky test (not flaky anymore) (#11478)

    I haven't seen these tests fail since the underlying issue was [fixed](flutter/flutter#183666) and [rolled](99155a8) in.
    
    Closes flutter/flutter#182844
    mdebbar authored Apr 30, 2026
    Configuration menu
    Copy the full SHA
    daf30f8 View commit details
    Browse the repository at this point in the history
Loading