Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 99155a8
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8dcfd11
Choose a head ref
  • 2 commits
  • 8 files changed
  • 2 contributors

Commits on Mar 19, 2026

  1. [camera] Make Optional.of constructor const (#11247) 

    Resolves old TODO from 2023 ( 6e09f5b committed by @camsim99 ) by making the `Optional.of` constructor `const` and removing the obsolete runtime `ArgumentError.checkNotNull` guard that was only needed during Dart 2's mixed-mode (unsound null safety) era. Mixed-mode execution was removed in Dart 3.0, so this is dead code. Not a breaking change.

Note that the entire `Optional<T>` class (and surrounding `CameraController`) is copy-pasted across 4 files in the camera packages. Would you prefer to move `Optional<T>` into `camera_platform_interface` to share it, or replace it entirely e.g. with a private sentinel pattern in `copyWith` (as the Flutter framework does for `ThemeData`)?

## Pre-Review Checklist
    @cdeil
    cdeil authored Mar 19, 2026
    Configuration menu
    Copy the full SHA
    c1f1167 View commit details
    Browse the repository at this point in the history

  2. [ci] grants write permission to create branch in remote (#11269) 

    The branch release workflow failed with

```
Parsing package "packages/packages/go_router"...
  Creating new branch "go_router-23134404669-1"...
  Pushing branch go_router-23134404669-1 to remote origin...
Unhandled exception:
ProcessException: remote: Permission to flutter/packages.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/flutter/packages/': The requested URL returned error: 403
  Command: git push origin go_router-23134404669-1
```

https://github.com/flutter/packages/actions/runs/23134404669/job/67194648551

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @chunhtai
    chunhtai authored Mar 19, 2026
    Configuration menu
    Copy the full SHA
    8dcfd11 View commit details
    Browse the repository at this point in the history
Loading